You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "aglinxinyuan (via GitHub)" <gi...@apache.org> on 2026/07/05 08:02:15 UTC
[PR] test(amber): add WorkflowActor receive-behavior tests [texera]
aglinxinyuan opened a new pull request, #6148:
URL: https://github.com/apache/texera/pull/6148
### What changes were proposed in this PR?
Adds `WorkflowActorSpec` (new) for the abstract `WorkflowActor` base (amber), which had no dedicated spec. Uses Pekko TestKit and the existing `TrivialControlTester` subclass to drive the receive behaviors in-JVM (no Python workers):
- `CreditRequest` → `CreditResponse(channel, 0)`, and `CreditResponse` forwarding to the transfer service;
- dead-letter handling — retry-to-self when the destination is this actor, and actor-ref removal otherwise;
- `RegisterActorRef` storing the ref, and `GetActorRef` for an unknown id forwarding to the parent;
- `sendMessageFromLogWriterToActor` / `handleTriggerSend` self-send and delegate paths.
`setupReplay` is left uncovered (it needs the serde/checkpoint-storage ceremony and has a known Windows file-handle quirk) — a candidate for a follow-up. No production code changed.
### Any related issues, documentation, discussions?
Coverage gaps identified from the Codecov report for `apache/texera` (amber module coverage push toward 80%).
### How was this PR tested?
```
sbt "WorkflowExecutionService/testOnly *WorkflowActorSpec"
```
All 10 pass. `scalafmt` and `scalafixAll --check` are clean.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.8 [1M context])
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(amber): add WorkflowActor receive-behavior tests [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan merged PR #6148:
URL: https://github.com/apache/texera/pull/6148
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(amber): add WorkflowActor receive-behavior tests [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #6148:
URL: https://github.com/apache/texera/pull/6148#issuecomment-4885321484
<!-- texera-reviewer-suggestion -->
### Automated Reviewer Suggestions
Based on the `git blame` history of the changed files, we recommend the following reviewers:
- No candidates found from `git blame` history.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(amber): add WorkflowActor receive-behavior tests [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #6148:
URL: https://github.com/apache/texera/pull/6148#issuecomment-4885347354
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/6148?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 59.85%. Comparing base ([`37354af`](https://app.codecov.io/gh/apache/texera/commit/37354af00265b4a0e521d2fb46b94efdf17b807f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`2aee870`](https://app.codecov.io/gh/apache/texera/commit/2aee8700a92d5fa328fad2621190b4649fb84892?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 4 commits behind head on main.
:white_check_mark: All tests successful. No failed tests found.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #6148 +/- ##
============================================
+ Coverage 59.81% 59.85% +0.03%
- Complexity 3295 3299 +4
============================================
Files 1133 1133
Lines 43801 43801
Branches 4748 4748
============================================
+ Hits 26201 26218 +17
+ Misses 16170 16153 -17
Partials 1430 1430
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/6148/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/6148/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `70.00% <ø> (ø)` | | Carriedforward from [37354af](https://app.codecov.io/gh/apache/texera/commit/37354af00265b4a0e521d2fb46b94efdf17b807f?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/6148/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.59% <ø> (ø)` | | Carriedforward from [37354af](https://app.codecov.io/gh/apache/texera/commit/37354af00265b4a0e521d2fb46b94efdf17b807f?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [amber](https://app.codecov.io/gh/apache/texera/pull/6148/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `64.86% <ø> (+0.10%)` | :arrow_up: | |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/6148/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (ø)` | | Carriedforward from [37354af](https://app.codecov.io/gh/apache/texera/commit/37354af00265b4a0e521d2fb46b94efdf17b807f?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/6148/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `52.30% <ø> (ø)` | | Carriedforward from [37354af](https://app.codecov.io/gh/apache/texera/commit/37354af00265b4a0e521d2fb46b94efdf17b807f?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/6148/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `62.81% <ø> (ø)` | | Carriedforward from [37354af](https://app.codecov.io/gh/apache/texera/commit/37354af00265b4a0e521d2fb46b94efdf17b807f?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/6148/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `51.51% <ø> (ø)` | | Carriedforward from [37354af](https://app.codecov.io/gh/apache/texera/commit/37354af00265b4a0e521d2fb46b94efdf17b807f?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [notebook-migration-service](https://app.codecov.io/gh/apache/texera/pull/6148/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `78.57% <ø> (ø)` | | Carriedforward from [37354af](https://app.codecov.io/gh/apache/texera/commit/37354af00265b4a0e521d2fb46b94efdf17b807f?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [pyamber](https://app.codecov.io/gh/apache/texera/pull/6148/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `91.19% <ø> (ø)` | | Carriedforward from [37354af](https://app.codecov.io/gh/apache/texera/commit/37354af00265b4a0e521d2fb46b94efdf17b807f?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/6148/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.14% <ø> (ø)` | | Carriedforward from [37354af](https://app.codecov.io/gh/apache/texera/commit/37354af00265b4a0e521d2fb46b94efdf17b807f?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/6148?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(amber): add WorkflowActor receive-behavior tests [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #6148:
URL: https://github.com/apache/texera/pull/6148#issuecomment-4885334828
<!-- texera-benchmarks-comment -->
## ⚠️ Benchmark changes need a look
🟢 0 better · 🔴 6 worse · ⚪ 9 noise (<±5%) · 0 without baseline
> Compared against main `92b7fc9` benchmarked on **this same runner**, so the delta is largely free of cross-runner hardware noise. The "7d avg" column still reflects the gh-pages dashboard. Treat <±5% as noise unless repeated.
[Dashboard](https://apache.github.io/texera/dev/bench/) · [Run](https://github.com/apache/texera/actions/runs/28734153800)
| | config | throughput | MB/s | latency | max Δ latest / 7d |
|---|---|---:|---:|---:|---:|
| 🔴 | bs=10 sw=10 sl=64 | 504 | 0.307 | 18,879/29,961/29,961 us | 🔴 +13.7% / 🔴 +97.9% |
| 🔴 | bs=100 sw=10 sl=64 | 1,105 | 0.674 | 89,103/116,416/116,416 us | 🔴 +12.4% / 🟢 -12.4% |
| ⚪ | bs=1000 sw=10 sl=64 | 1,246 | 0.76 | 802,723/849,737/849,737 us | ⚪ within ±5% / 🟢 +22.6% |
<details><summary>Baseline details</summary>
Latest main `92b7fc9` from same runner
| config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
|---|---|---:|---:|---:|---:|---:|
| bs=10 sw=10 sl=64 | throughput | 504 tuples/sec | 531 tuples/sec | 776.36 tuples/sec | -5.1% | -35.1% |
| bs=10 sw=10 sl=64 | MB/s | 0.307 MB/s | 0.324 MB/s | 0.474 MB/s | -5.2% | -35.2% |
| bs=10 sw=10 sl=64 | p50 | 18,879 us | 18,259 us | 12,636 us | +3.4% | +49.4% |
| bs=10 sw=10 sl=64 | p95 | 29,961 us | 26,348 us | 15,143 us | +13.7% | +97.9% |
| bs=10 sw=10 sl=64 | p99 | 29,961 us | 26,348 us | 18,954 us | +13.7% | +58.1% |
| bs=100 sw=10 sl=64 | throughput | 1,105 tuples/sec | 1,123 tuples/sec | 985.33 tuples/sec | -1.6% | +12.1% |
| bs=100 sw=10 sl=64 | MB/s | 0.674 MB/s | 0.686 MB/s | 0.601 MB/s | -1.7% | +12.1% |
| bs=100 sw=10 sl=64 | p50 | 89,103 us | 86,654 us | 101,671 us | +2.8% | -12.4% |
| bs=100 sw=10 sl=64 | p95 | 116,416 us | 103,529 us | 107,939 us | +12.4% | +7.9% |
| bs=100 sw=10 sl=64 | p99 | 116,416 us | 103,529 us | 113,798 us | +12.4% | +2.3% |
| bs=1000 sw=10 sl=64 | throughput | 1,246 tuples/sec | 1,241 tuples/sec | 1,016 tuples/sec | +0.4% | +22.6% |
| bs=1000 sw=10 sl=64 | MB/s | 0.76 MB/s | 0.758 MB/s | 0.62 MB/s | +0.3% | +22.5% |
| bs=1000 sw=10 sl=64 | p50 | 802,723 us | 804,240 us | 989,693 us | -0.2% | -18.9% |
| bs=1000 sw=10 sl=64 | p95 | 849,737 us | 861,942 us | 1,028,327 us | -1.4% | -17.4% |
| bs=1000 sw=10 sl=64 | p99 | 849,737 us | 861,942 us | 1,059,969 us | -1.4% | -19.8% |
</details>
<details><summary>Raw CSV</summary>
```csv
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,397.03,200,128000,504,0.307,18879.26,29961.05,29961.05
1,100,10,64,20,1810.60,2000,1280000,1105,0.674,89103.00,116416.04,116416.04
2,1000,10,64,20,16056.30,20000,12800000,1246,0.760,802722.50,849736.79,849736.79
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org