[GitHub] [spark] Yikun commented on pull request #32246: [SPARK-35143][ML] Simplify Python for loop code

[GitBox <gi...@apache.org>]

Yikun commented on pull request #32246:
URL: https://github.com/apache/spark/pull/32246#issuecomment-823709270


   @ChenDou2021 Hi, thanks for the contributions, as mentioned from @HyukjinKwon , the changes in your patch are all coding style preference (also, there were some pros and cons discussion on list comprehes, such as [link](https://stackoverflow.com/questions/2849645/in-python-is-it-better-to-use-list-comprehensions-or-for-each-loops)), so these changes would not be considered to be merged into main line code.
   
   Btw, the failing test is due to the branch name is branch-3.2, the fork build test was filtered by https://github.com/apache/spark/blob/81c3cc2312aaa730fa025159f56703170172c454/.github/workflows/build_and_test.yml#L7
   and the notify test can't find the job in your fork repo. If you have futher PR to submit, you should consider rename your branch to something like (SPARK-XXX or other name except branch-XXX).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org