You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by sk...@apache.org on 2008/06/24 16:25:56 UTC

svn commit: r671187 - in /myfaces/orchestra/branches/prepare_core12/src/main/java/org/apache/myfaces/orchestra/frameworkAdapter/springBasic: SpringBasicFrameworkAdapter.java SpringBasicFrameworkAdapterFilter.java

Author: skitching
Date: Tue Jun 24 07:25:56 2008
New Revision: 671187

URL: http://svn.apache.org/viewvc?rev=671187&view=rev
Log:
Improve comments, fix code style.

Modified:
    myfaces/orchestra/branches/prepare_core12/src/main/java/org/apache/myfaces/orchestra/frameworkAdapter/springBasic/SpringBasicFrameworkAdapter.java
    myfaces/orchestra/branches/prepare_core12/src/main/java/org/apache/myfaces/orchestra/frameworkAdapter/springBasic/SpringBasicFrameworkAdapterFilter.java

Modified: myfaces/orchestra/branches/prepare_core12/src/main/java/org/apache/myfaces/orchestra/frameworkAdapter/springBasic/SpringBasicFrameworkAdapter.java
URL: http://svn.apache.org/viewvc/myfaces/orchestra/branches/prepare_core12/src/main/java/org/apache/myfaces/orchestra/frameworkAdapter/springBasic/SpringBasicFrameworkAdapter.java?rev=671187&r1=671186&r2=671187&view=diff
==============================================================================
--- myfaces/orchestra/branches/prepare_core12/src/main/java/org/apache/myfaces/orchestra/frameworkAdapter/springBasic/SpringBasicFrameworkAdapter.java (original)
+++ myfaces/orchestra/branches/prepare_core12/src/main/java/org/apache/myfaces/orchestra/frameworkAdapter/springBasic/SpringBasicFrameworkAdapter.java Tue Jun 24 07:25:56 2008
@@ -26,20 +26,25 @@
 
 /**
  * Same as {@link BasicFrameworkAdapter} but lookup the bean using the Spring framework.
+ * <p>
+ * This makes it possible to configure Orchestra to look up beans from a Spring context
+ * even when there is no ServletContext or FacesContext available.
  *
  * @see BasicFrameworkAdapter
  */
-public class SpringBasicFrameworkAdapter extends BasicFrameworkAdapter {
-
+public class SpringBasicFrameworkAdapter extends BasicFrameworkAdapter
+{
     private final ServletContext context;
 
-    public SpringBasicFrameworkAdapter(ServletContext context, String conversationMessagerClass) {
+    public SpringBasicFrameworkAdapter(ServletContext context, String conversationMessagerClass)
+    {
         super(context, conversationMessagerClass);
 
         this.context = context;
     }
 
-    public Object getBean(String name) {
+    public Object getBean(String name)
+    {
         ApplicationContext appContext = WebApplicationContextUtils.getRequiredWebApplicationContext(context);
         return appContext.getBean(name);
     }

Modified: myfaces/orchestra/branches/prepare_core12/src/main/java/org/apache/myfaces/orchestra/frameworkAdapter/springBasic/SpringBasicFrameworkAdapterFilter.java
URL: http://svn.apache.org/viewvc/myfaces/orchestra/branches/prepare_core12/src/main/java/org/apache/myfaces/orchestra/frameworkAdapter/springBasic/SpringBasicFrameworkAdapterFilter.java?rev=671187&r1=671186&r2=671187&view=diff
==============================================================================
--- myfaces/orchestra/branches/prepare_core12/src/main/java/org/apache/myfaces/orchestra/frameworkAdapter/springBasic/SpringBasicFrameworkAdapterFilter.java (original)
+++ myfaces/orchestra/branches/prepare_core12/src/main/java/org/apache/myfaces/orchestra/frameworkAdapter/springBasic/SpringBasicFrameworkAdapterFilter.java Tue Jun 24 07:25:56 2008
@@ -37,11 +37,11 @@
  * <p>
  * Orchestra accesses information about the request, response, session, etc via a
  * FrameworkAdapter so that it can be used with multiple web tier frameworks. This
- * class selects and configures the simplest version of this adapter, which only
- * depends on the <i>basic</i> Servlet APIs.
+ * class selects and configures a version of this adapter which looks up variables
+ * via Spring.
  * <p>
  * If filter config parameter "conversationMessagerClass" is set, then this is
- * passed to the BasicFrameworkAdapter, meaning that this can be either a
+ * passed to the SpringBasicFrameworkAdapter, meaning that this can be either a
  * beanname defined in the dependency-injection framework, or an absolute
  * classname of a type implementing ConversationMessager.
  * <p>