[GitHub] [airflow] potiuk commented on pull request #8594: Reduce duplication of functions called in ci scripts

[GitBox <gi...@apache.org>]

potiuk commented on pull request #8594:
URL: https://github.com/apache/airflow/pull/8594#issuecomment-620545404


   The change is not compleete and I do not think it's worth it. I am not sure what it would bring.
   
   This method run separately and explicitly is there to prepare variables for CI build - not run the build itself. and it is deliberately named like that to make sure that it is "preparation" rather than "build". I prefer single-responsibility principle as it makes it cleaner where things have to be changed. 
   
   I am already using that single-responsibility principle - you probably missed all the usage of those methods in the "breeze" script as it does not end with .sh
   
   The methods and builds of images  can be triggered in various places:
   * ci_scripts (used in Github Actions/Travis)
   * pre-commit scripts 
   * breeze
   
   There are a number of places in `breeze` script that the method is used separately - just to set the variables and act on those variables before the build happens. There are things happening between that method and running the build itself  - for example cleaning the build cache between prepare and build or separation of the prepare/build in breeze when we choose which command should be executed. 
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org