You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Paul Elschot (JIRA)" <ji...@apache.org> on 2015/05/18 21:21:59 UTC
[jira] [Comment Edited] (LUCENE-6466) Move SpanQuery.getSpans() to
SpanWeight
[ https://issues.apache.org/jira/browse/LUCENE-6466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14548586#comment-14548586 ]
Paul Elschot edited comment on LUCENE-6466 at 5/18/15 7:21 PM:
---------------------------------------------------------------
The (2nd) patch looks good in the sense of making SpanWeight.getSpans() consistent with Weight.scorer().
This also introduces SpanSimilarity, which makes sense.
On the extra complexity of the SpanWeights that are added for each SpanQuery: at the moment these SpanWeights don't do much, but they are good to have because they can be overridden separately.
I think these SpanWeights can also allow adding a scoring method to Spans, but perhaps that is better done at another issue.
was (Author: paul.elschot@xs4all.nl):
The patch looks good in the sense of making SpanWeight.getSpans() consistent with Weight.scorer().
This also introduces SpanSimilarity, which makes sense.
On the extra complexity of the SpanWeights that are added for each SpanQuery: at the moment these SpanWeights don't do much, but they are good to have because they can be overridden separately.
I think these SpanWeights can also allow adding a scoring method to Spans, but perhaps that is better done at another issue.
> Move SpanQuery.getSpans() to SpanWeight
> ---------------------------------------
>
> Key: LUCENE-6466
> URL: https://issues.apache.org/jira/browse/LUCENE-6466
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Alan Woodward
> Priority: Minor
> Attachments: LUCENE-6466.patch, LUCENE-6466.patch, LUCENE-6466.patch
>
>
> SpanQuery.getSpans() should only be called on rewritten queries, so it seems to make more sense to have this being called from SpanWeight
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org