You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by GitBox <gi...@apache.org> on 2022/04/04 12:08:39 UTC
[GitHub] [daffodil] scala-steward opened a new pull request, #783: Update scala-xml to 2.1.0
scala-steward opened a new pull request, #783:
URL: https://github.com/apache/daffodil/pull/783
Updates [org.scala-lang.modules:scala-xml](https://github.com/scala/scala-xml) from 2.0.1 to 2.1.0.
[GitHub Release Notes](https://github.com/scala/scala-xml/releases/tag/v2.1.0) - [Version Diff](https://github.com/scala/scala-xml/compare/v2.0.1...v2.1.0)
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a [`.scala-steward.conf`](https://github.com/scala-steward-org/scala-steward/blob/3e73a5b063d3b01380e2fee4532cffaef17e3047/docs/repo-specific-configuration.md) file.
Have a fantastic day writing Scala!
<details>
<summary>Files still referring to the old version number</summary>
The following files still refer to the old version number (2.0.1).
You might want to review and update them manually.
```
containers/release-candidate/setup-container.sh
```
</details>
<details>
<summary>Ignore future updates</summary>
Add this to your `.scala-steward.conf` file to ignore future updates of this dependency:
```
updates.ignore = [ { groupId = "org.scala-lang.modules", artifactId = "scala-xml" } ]
```
</details>
labels: library-update, early-semver-minor, semver-spec-minor, old-version-remains, commit-count:1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil] mbeckerle commented on pull request #783: Update scala-xml to 2.1.0
Posted by GitBox <gi...@apache.org>.
mbeckerle commented on PR #783:
URL: https://github.com/apache/daffodil/pull/783#issuecomment-1092814786
Yes I suppose we should just close it. Closing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil] mbeckerle commented on pull request #783: Update scala-xml to 2.1.0
Posted by GitBox <gi...@apache.org>.
mbeckerle commented on PR #783:
URL: https://github.com/apache/daffodil/pull/783#issuecomment-1088762507
Let's leave this PR open. I'll create a JIRA ticket for upgrade to Scala XML 2.1.0 version.
We really do have to look at this carefully. Scala XML support is evolving radically in the transition from Scala 2.12 to 2.13 and 3.x. (I have my doubts about whether we will ever upgrade to Scala 3 actually)
OTOH: there are some annoying XML bugs that really do actually impact DFDL schemas - e.g., scala xml not handling character 0xB properly, etc. that actually are hard to work around for us. I'm hoping these are fixed in scala xml 2.1.0.
But that said, no point putting a great deal of work into fixing this if it's all going to be scrap when we upgrade to a newer Scala.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil] mbeckerle closed pull request #783: Update scala-xml to 2.1.0
Posted by GitBox <gi...@apache.org>.
mbeckerle closed pull request #783: Update scala-xml to 2.1.0
URL: https://github.com/apache/daffodil/pull/783
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil] mbeckerle commented on pull request #783: Update scala-xml to 2.1.0
Posted by GitBox <gi...@apache.org>.
mbeckerle commented on PR #783:
URL: https://github.com/apache/daffodil/pull/783#issuecomment-1088812309
See https://issues.apache.org/jira/browse/DAFFODIL-2685
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil] stevedlawrence commented on pull request #783: Update scala-xml to 2.1.0
Posted by GitBox <gi...@apache.org>.
stevedlawrence commented on PR #783:
URL: https://github.com/apache/daffodil/pull/783#issuecomment-1092787779
Should we close this PR now that we have the JIRA issue to track the upgrade? This PR will never be merged until someone takes on the issue and fixes the regressions, at which point they can create a new PR, so this is sort of just a distraction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org