[GitHub] [skywalking-java] sunOnly commented on a change in pull request #96: [Feature] Support collecting database connection pool metric,support druid/hikari #8450

[GitBox <gi...@apache.org>]

sunOnly commented on a change in pull request #96:
URL: https://github.com/apache/skywalking-java/pull/96#discussion_r794235685



##########
File path: apm-sniffer/apm-sdk-plugin/dbcp-2.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/dbcp/v2/define/BasicDataSourceInstrumentation.java
##########
@@ -72,4 +90,9 @@ public boolean isOverrideArgs() {
     public StaticMethodsInterceptPoint[] getStaticMethodsInterceptPoints() {
         return new StaticMethodsInterceptPoint[0];
     }
+
+    @Override
+    public boolean isBootstrapInstrumentation() {
+        return true;

Review comment:
       Without rewriting, enhancement does not work




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org