You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/02/06 00:42:55 UTC
[GitHub] codecov-io edited a comment on issue #6618: Support
preselect_filters without filter_box IDs
codecov-io edited a comment on issue #6618: Support preselect_filters without filter_box IDs
URL: https://github.com/apache/incubator-superset/pull/6618#issuecomment-454856198
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/6618?src=pr&el=h1) Report
> Merging [#6618](https://codecov.io/gh/apache/incubator-superset/pull/6618?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6e9130550dd07e2b7a8e2c819ee6f212a34c28cb?src=pr&el=desc) will **increase** coverage by `0.31%`.
> The diff coverage is `95.74%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/6618?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6618 +/- ##
==========================================
+ Coverage 56.16% 56.48% +0.31%
==========================================
Files 527 528 +1
Lines 23318 23348 +30
Branches 2794 2802 +8
==========================================
+ Hits 13096 13187 +91
+ Misses 9812 9758 -54
+ Partials 410 403 -7
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/6618?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset/assets/src/dashboard/components/SaveModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/6618/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9TYXZlTW9kYWwuanN4) | `46.15% <ø> (ø)` | :arrow_up: |
| [...uperset/assets/src/dashboard/components/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/6618/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9IZWFkZXIuanN4) | `41.11% <ø> (ø)` | :arrow_up: |
| [.../assets/src/visualizations/FilterBox/FilterBox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/6618/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9GaWx0ZXJCb3gvRmlsdGVyQm94LmpzeA==) | `0% <0%> (ø)` | :arrow_up: |
| [...erset/assets/src/dashboard/util/getDashboardUrl.js](https://codecov.io/gh/apache/incubator-superset/pull/6618/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvdXRpbC9nZXREYXNoYm9hcmRVcmwuanM=) | `100% <100%> (ø)` | :arrow_up: |
| [...t/assets/src/dashboard/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/6618/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLmpz) | `94.52% <100%> (+94.52%)` | :arrow_up: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/6618/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.07% <100%> (+0.05%)` | :arrow_up: |
| [...uperset/assets/src/dashboard/util/filterOptions.js](https://codecov.io/gh/apache/incubator-superset/pull/6618/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvdXRpbC9maWx0ZXJPcHRpb25zLmpz) | `93.75% <93.75%> (ø)` | |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/6618/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `83.59% <0%> (+0.15%)` | :arrow_up: |
| ... and [1 more](https://codecov.io/gh/apache/incubator-superset/pull/6618/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/6618?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/6618?src=pr&el=footer). Last update [6e91305...f372332](https://codecov.io/gh/apache/incubator-superset/pull/6618?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org