You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "annanys23 (via GitHub)" <gi...@apache.org> on 2023/10/13 18:30:02 UTC
[PR] NIFI-12030 Property pop-up window is horizontally resizable [nifi]
annanys23 opened a new pull request, #7883:
URL: https://github.com/apache/nifi/pull/7883
<!-- Licensed to the Apache Software Foundation (ASF) under one or more -->
<!-- contributor license agreements. See the NOTICE file distributed with -->
<!-- this work for additional information regarding copyright ownership. -->
<!-- The ASF licenses this file to You under the Apache License, Version 2.0 -->
<!-- (the "License"); you may not use this file except in compliance with -->
<!-- the License. You may obtain a copy of the License at -->
<!-- http://www.apache.org/licenses/LICENSE-2.0 -->
<!-- Unless required by applicable law or agreed to in writing, software -->
<!-- distributed under the License is distributed on an "AS IS" BASIS, -->
<!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -->
<!-- See the License for the specific language governing permissions and -->
<!-- limitations under the License. -->
# Summary
[NIFI-12030](https://issues.apache.org/jira/browse/NIFI-12030)
When a property of a controller service or processor is a list of values, the combo box is now horizontally resizable when open.
# Tracking
### Issue Tracking
- [x ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
### Pull Request Formatting
- [x] Pull Request based on current revision of the `main` branch
- [x] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [x] Build completed using `mvn clean install -P contrib-check`
- [x] JDK 21
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [x] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-12030 Property pop-up window is horizontally resizable [nifi]
Posted by "annanys23 (via GitHub)" <gi...@apache.org>.
annanys23 commented on PR #7883:
URL: https://github.com/apache/nifi/pull/7883#issuecomment-1788877630
I don't have any other thoughts on this. Thank you all for your input.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-12030 Property pop-up window is horizontally resizable [nifi]
Posted by "scottyaslan (via GitHub)" <gi...@apache.org>.
scottyaslan commented on PR #7883:
URL: https://github.com/apache/nifi/pull/7883#issuecomment-1787710342
This case is already addressed in the UI. For long values, the text is truncated with the ellipsis:
The user can hover over the value to see the title tooltip:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-12030 Property pop-up window is horizontally resizable [nifi]
Posted by "koccs (via GitHub)" <gi...@apache.org>.
koccs commented on PR #7883:
URL: https://github.com/apache/nifi/pull/7883#issuecomment-1785372579
Probably it is less comfortable because it requires hover over the options, but if any text is truncated with an ellipsis then a tooltip (with the full text) is the most commonly used solution in the industry.
Although it is not the best in the perspective of accessibility, but neither the resize handle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-12030 Property pop-up window is horizontally resizable [nifi]
Posted by "annanys23 (via GitHub)" <gi...@apache.org>.
annanys23 closed pull request #7883: NIFI-12030 Property pop-up window is horizontally resizable
URL: https://github.com/apache/nifi/pull/7883
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-12030 Property pop-up window is horizontally resizable [nifi]
Posted by "annanys23 (via GitHub)" <gi...@apache.org>.
annanys23 commented on PR #7883:
URL: https://github.com/apache/nifi/pull/7883#issuecomment-1781477366
Thanks for looking at this @Lehel44 and @exceptionfactory. How about I change the behavior as follows: when the combo-box is opened and resized, the whole pop-up is resized with it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org