[GitHub] [spark] dgd-contributor commented on a change in pull request #33968: [SPARK-36722][PYTHON] Fix Series.update with another in same frame

[GitBox <gi...@apache.org>]

dgd-contributor commented on a change in pull request #33968:
URL: https://github.com/apache/spark/pull/33968#discussion_r707894293



##########
File path: python/pyspark/pandas/series.py
##########
@@ -4548,22 +4548,31 @@ def update(self, other: "Series") -> None:
         if not isinstance(other, Series):
             raise TypeError("'other' must be a Series")
 
-        combined = combine_frames(self._psdf, other._psdf, how="leftouter")
+        if same_anchor(self, other):
+            scol = F.when(other.spark.column.isNotNull(), other.spark.column).otherwise(
+                self.spark.column
+            )

Review comment:
       thanks , updated




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org