[GitHub] [spark] dongjoon-hyun commented on a change in pull request #34723: [SPARK-37492][SQL] Optimize Orc test code with withAllNativeOrcReaders

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #34723:
URL: https://github.com/apache/spark/pull/34723#discussion_r758929249



##########
File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/HiveOrcQuerySuite.scala
##########
@@ -288,10 +288,9 @@ class HiveOrcQuerySuite extends OrcQueryTest with TestHiveSingleton {
 
   test("SPARK-32234 read ORC table with column names all starting with '_col'") {
     Seq("native", "hive").foreach { orcImpl =>
-      Seq("false", "true").foreach { vectorized =>
-        withSQLConf(
-          SQLConf.ORC_IMPLEMENTATION.key -> orcImpl,
-          SQLConf.ORC_VECTORIZED_READER_ENABLED.key -> vectorized) {
+      withSQLConf(
+        SQLConf.ORC_IMPLEMENTATION.key -> orcImpl) {
+        withAllNativeOrcReaders {

Review comment:
       Ur, @beliefer . This is technically correct, but logically misleading again. When `orcImpl=hive`, we are not testing `nativeOrcReaders`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org