[jira] [Commented] (OAK-4605) Separate persistent cache for diff and local_diff

["Thomas Mueller (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15395581#comment-15395581 ] 

Thomas Mueller commented on OAK-4605:
-------------------------------------

I didn't test the patch yet, but in general it looks good to me. As far as I see, the broadcast feature doesn't work for the journal when using a separate journal store, not sure if that's a problem (probably not, but something to consider).



> Separate persistent cache for diff and local_diff
> -------------------------------------------------
>
>                 Key: OAK-4605
>                 URL: https://issues.apache.org/jira/browse/OAK-4605
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core, documentmk
>            Reporter: Marcel Reutegger
>            Assignee: Marcel Reutegger
>             Fix For: 1.6
>
>         Attachments: OAK-4605.patch
>
>
> The DocumentNodeStore currently uses a single persistent cache for all types (node, nodeChildren, diff, etc.). With this setup it is not possible to assign a specific amount of disk space for some cache type(s). If there are many inserts for one cache type, entries of another type may become unavailable. In practice this can be a problem for the local_diff cache entries that are important for efficient node state comparison.
> Separating the diff and local_diff cache entries would also allow for different configuration options like compression and different behaviour when the async write back queue is full.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)