[jira] [Reopened] (HBASE-21959) CompactionTool should close the store it uses for compacting files, in order to properly archive compacted files.

["Andrew Purtell (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HBASE-21959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Purtell reopened HBASE-21959:
------------------------------------

Git bisecting recent unit test instability landed on this commit twice. At first glance it's hard to see what the problem could be except there is a new unit added here. Testing revert and recommit without the new unit looks promising. The failure was intermittent so it may take some time to confirm with enough iterations that removing the unit test here is a short term solution to unblock releasing from branch-1. If so I will push up the revert and amended commit to the branch-1s.

> CompactionTool should close the store it uses for compacting files, in order to properly archive compacted files.
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-21959
>                 URL: https://issues.apache.org/jira/browse/HBASE-21959
>             Project: HBase
>          Issue Type: Bug
>          Components: tooling
>            Reporter: Wellington Chevreuil
>            Assignee: Wellington Chevreuil
>            Priority: Major
>             Fix For: 3.0.0, 1.5.0, 1.4.10, 2.3.0
>
>         Attachments: HBASE-21959-branch-1-001.patch, HBASE-21959-branch-1-002.patch, HBASE-21959-master-001.patch, HBASE-21959-master-002.patch, HBASE-21959-master-003.patch
>
>
> While using CompactionTool to offload RSes, noticed compacted files were never archived from original region dir, causing the space used by the region to actually double. Going through its compaction related code on HStore, which is used by CompactionTool for performing compactions, found out what that compacted files archiving happens mainly while closing the HStore instance. CompactionTool is never explicitly closing its HStore instance, so adding a simple patch that properly close the store.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)