[GitHub] [hadoop] anoopsjohn commented on a change in pull request #2795: HADOOP-17596. ABFS: Change default Readahead Queue Depth from num(processors) to const

[GitBox <gi...@apache.org>]

anoopsjohn commented on a change in pull request #2795:
URL: https://github.com/apache/hadoop/pull/2795#discussion_r631605580



##########
File path: hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/TestAbfsInputStream.java
##########
@@ -569,6 +570,20 @@ public void testDiffReadRequestSizeAndRAHBlockSize() throws Exception {
     testReadAheads(inputStream, FORTY_EIGHT_KB, SIXTEEN_KB);
   }
 
+  @Test
+  public void testDefaultReadaheadQueueDepth() throws Exception {
+    Configuration config = getRawConfiguration();
+    config.unset("fs.azure.readaheadqueue.depth");

Review comment:
       This in effect change this config (Is set already) for this test class.  As we direct change in Raw config.
   Should we create a cloned conf from rawConfig and on that unset and use that for FS created for this method?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org