You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2019/12/24 13:10:29 UTC
[GitHub] [skywalking] wu-sheng opened a new pull request #4119: Update JDK
compiling level to 8, and remove zip dist.
wu-sheng opened a new pull request #4119: Update JDK compiling level to 8, and remove zip dist.
URL: https://github.com/apache/skywalking/pull/4119
This change based on the PMC and community vote. All agents in 7.x will only consider JDK8 compatible.
And I removed the zip dist from 7.x, as the release tarballs are too many and too large without benefit.
@dmsolr @arugal Do any of you have time to move optional plugins caused by JDK8 requirements into the default plugins, and change the plugin test scripts? I think inducing
1. Lettuce
1. Play Framework
1. Spring Webflux 5.x
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io commented on issue #4119: Update JDK
compiling level to 8, and remove zip dist.
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4119: Update JDK compiling level to 8, and remove zip dist.
URL: https://github.com/apache/skywalking/pull/4119#issuecomment-568753962
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4119?src=pr&el=h1) Report
> Merging [#4119](https://codecov.io/gh/apache/skywalking/pull/4119?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9dcd3c74de5c90230f6fa59831d40c9be05df4c7?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `16.66%`.
[](https://codecov.io/gh/apache/skywalking/pull/4119?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4119 +/- ##
==========================================
- Coverage 27.26% 27.26% -0.01%
==========================================
Files 1140 1140
Lines 25024 25026 +2
Branches 3619 3620 +1
==========================================
Hits 6823 6823
- Misses 17595 17597 +2
Partials 606 606
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4119?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ver/core/query/ServiceInstanceTopologyBuilder.java](https://codecov.io/gh/apache/skywalking/pull/4119/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcXVlcnkvU2VydmljZUluc3RhbmNlVG9wb2xvZ3lCdWlsZGVyLmphdmE=) | `0% <ø> (ø)` | :arrow_up: |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/4119/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `0% <0%> (ø)` | :arrow_up: |
| [...ing/oap/server/library/client/grpc/GRPCClient.java](https://codecov.io/gh/apache/skywalking/pull/4119/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2dycGMvR1JQQ0NsaWVudC5qYXZh) | `0% <0%> (ø)` | :arrow_up: |
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/4119/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `85.71% <0%> (-3.18%)` | :arrow_down: |
| [.../apm/agent/core/remote/StandardChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/4119/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1N0YW5kYXJkQ2hhbm5lbEJ1aWxkZXIuamF2YQ==) | `100% <100%> (ø)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4119?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4119?src=pr&el=footer). Last update [9dcd3c7...855259b](https://codecov.io/gh/apache/skywalking/pull/4119?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4119: Update JDK
compiling level to 8, and remove zip dist.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4119: Update JDK compiling level to 8, and remove zip dist.
URL: https://github.com/apache/skywalking/pull/4119#issuecomment-568751220
I am fixing the more deps in jar. They need to be shaded.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4119:
Update JDK compiling level to 8, and remove zip dist.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4119: Update JDK compiling level to 8, and remove zip dist.
URL: https://github.com/apache/skywalking/pull/4119#discussion_r361267498
##########
File path: oap-server/server-cluster-plugin/cluster-kubernetes-plugin/src/main/java/org/apache/skywalking/oap/server/cluster/plugin/kubernetes/KubernetesCoordinator.java
##########
@@ -60,27 +60,29 @@
}
public void start() {
- submitTask(MoreExecutors.listeningDecorator(Executors.newSingleThreadExecutor(new ThreadFactoryBuilder()
- .setDaemon(true).setNameFormat("Kubernetes-ApiServer-%s").build())));
+ ExecutorService executorService = Executors.newSingleThreadExecutor(new ThreadFactoryBuilder()
+ .setDaemon(true).setNameFormat("Kubernetes-ApiServer-%s").build());
+ submitTask(MoreExecutors.listeningDecorator(executorService), executorService);
Review comment:
@hanahmily I changed this due to Guava lib upgrade. Could you recheck this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng merged pull request #4119: Update JDK
compiling level to 8, and remove zip dist.
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #4119: Update JDK compiling level to 8, and remove zip dist.
URL: https://github.com/apache/skywalking/pull/4119
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4119: Update JDK
compiling level to 8, and remove zip dist.
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4119: Update JDK compiling level to 8, and remove zip dist.
URL: https://github.com/apache/skywalking/pull/4119#issuecomment-568753962
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4119?src=pr&el=h1) Report
> Merging [#4119](https://codecov.io/gh/apache/skywalking/pull/4119?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/bf6491f4496a91cee6c10cdf15aa7f6054e57049?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `16.66%`.
[](https://codecov.io/gh/apache/skywalking/pull/4119?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4119 +/- ##
==========================================
- Coverage 27.23% 27.23% -0.01%
==========================================
Files 1141 1141
Lines 25054 25056 +2
Branches 3624 3625 +1
==========================================
Hits 6823 6823
- Misses 17625 17627 +2
Partials 606 606
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4119?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ver/core/query/ServiceInstanceTopologyBuilder.java](https://codecov.io/gh/apache/skywalking/pull/4119/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcXVlcnkvU2VydmljZUluc3RhbmNlVG9wb2xvZ3lCdWlsZGVyLmphdmE=) | `0% <ø> (ø)` | :arrow_up: |
| [...ing/oap/server/library/client/grpc/GRPCClient.java](https://codecov.io/gh/apache/skywalking/pull/4119/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2dycGMvR1JQQ0NsaWVudC5qYXZh) | `0% <0%> (ø)` | :arrow_up: |
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/4119/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `85.71% <0%> (-3.18%)` | :arrow_down: |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/4119/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `0% <0%> (ø)` | :arrow_up: |
| [.../apm/agent/core/remote/StandardChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/4119/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1N0YW5kYXJkQ2hhbm5lbEJ1aWxkZXIuamF2YQ==) | `100% <100%> (ø)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4119?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4119?src=pr&el=footer). Last update [bf6491f...ec3890c](https://codecov.io/gh/apache/skywalking/pull/4119?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4119: Update JDK
compiling level to 8, and remove zip dist.
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4119: Update JDK compiling level to 8, and remove zip dist.
URL: https://github.com/apache/skywalking/pull/4119#issuecomment-568753962
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4119?src=pr&el=h1) Report
> Merging [#4119](https://codecov.io/gh/apache/skywalking/pull/4119?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/2b9aef370752c00ced4693dcd1404e058a54e2f3?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4119?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4119 +/- ##
=======================================
Coverage 27.23% 27.23%
=======================================
Files 1141 1141
Lines 25057 25057
Branches 3625 3625
=======================================
Hits 6824 6824
Misses 17627 17627
Partials 606 606
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4119?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4119?src=pr&el=footer). Last update [2b9aef3...d24f91d](https://codecov.io/gh/apache/skywalking/pull/4119?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4119: Update JDK
compiling level to 8, and remove zip dist.
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4119: Update JDK compiling level to 8, and remove zip dist.
URL: https://github.com/apache/skywalking/pull/4119#issuecomment-568753962
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4119?src=pr&el=h1) Report
> Merging [#4119](https://codecov.io/gh/apache/skywalking/pull/4119?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/5fba1cf14c6510dfb08a03aa32bbfabc26e74a60?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4119?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4119 +/- ##
=======================================
Coverage 27.17% 27.17%
=======================================
Files 1141 1141
Lines 25057 25057
Branches 3625 3625
=======================================
Hits 6810 6810
Misses 17644 17644
Partials 603 603
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4119?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4119?src=pr&el=footer). Last update [5fba1cf...2b9aef3](https://codecov.io/gh/apache/skywalking/pull/4119?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4119: Update JDK
compiling level to 8, and remove zip dist.
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4119: Update JDK compiling level to 8, and remove zip dist.
URL: https://github.com/apache/skywalking/pull/4119#issuecomment-568753962
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4119?src=pr&el=h1) Report
> Merging [#4119](https://codecov.io/gh/apache/skywalking/pull/4119?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/bf6491f4496a91cee6c10cdf15aa7f6054e57049?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `16.66%`.
[](https://codecov.io/gh/apache/skywalking/pull/4119?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4119 +/- ##
==========================================
- Coverage 27.26% 27.26% -0.01%
==========================================
Files 1140 1140
Lines 25024 25026 +2
Branches 3619 3620 +1
==========================================
Hits 6823 6823
- Misses 17595 17597 +2
Partials 606 606
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4119?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ver/core/query/ServiceInstanceTopologyBuilder.java](https://codecov.io/gh/apache/skywalking/pull/4119/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcXVlcnkvU2VydmljZUluc3RhbmNlVG9wb2xvZ3lCdWlsZGVyLmphdmE=) | `0% <ø> (ø)` | :arrow_up: |
| [...ing/oap/server/library/client/grpc/GRPCClient.java](https://codecov.io/gh/apache/skywalking/pull/4119/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2dycGMvR1JQQ0NsaWVudC5qYXZh) | `0% <0%> (ø)` | :arrow_up: |
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/4119/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `85.71% <0%> (-3.18%)` | :arrow_down: |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/4119/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `0% <0%> (ø)` | :arrow_up: |
| [.../apm/agent/core/remote/StandardChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/4119/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1N0YW5kYXJkQ2hhbm5lbEJ1aWxkZXIuamF2YQ==) | `100% <100%> (ø)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4119?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4119?src=pr&el=footer). Last update [bf6491f...ec3890c](https://codecov.io/gh/apache/skywalking/pull/4119?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4119: Update JDK
compiling level to 8, and remove zip dist.
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4119: Update JDK compiling level to 8, and remove zip dist.
URL: https://github.com/apache/skywalking/pull/4119#issuecomment-568753962
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4119?src=pr&el=h1) Report
> Merging [#4119](https://codecov.io/gh/apache/skywalking/pull/4119?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/2a4f5998d9f6593d3064747c26af087593d4b74d?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/skywalking/pull/4119?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4119 +/- ##
=======================================
Coverage 27.26% 27.26%
=======================================
Files 1140 1140
Lines 25026 25026
Branches 3620 3620
=======================================
Hits 6823 6823
Misses 17597 17597
Partials 606 606
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4119?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...alking/apm/agent/core/logging/core/FileWriter.java](https://codecov.io/gh/apache/skywalking/pull/4119/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0ZpbGVXcml0ZXIuamF2YQ==) | `83.72% <100%> (ø)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4119?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4119?src=pr&el=footer). Last update [2a4f599...d381844](https://codecov.io/gh/apache/skywalking/pull/4119?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4119: Update JDK
compiling level to 8, and remove zip dist.
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4119: Update JDK compiling level to 8, and remove zip dist.
URL: https://github.com/apache/skywalking/pull/4119#issuecomment-568753962
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4119?src=pr&el=h1) Report
> Merging [#4119](https://codecov.io/gh/apache/skywalking/pull/4119?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/ba192a9f1301e982211a1f5a0e13fe7f610810b7?src=pr&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `54.54%`.
[](https://codecov.io/gh/apache/skywalking/pull/4119?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4119 +/- ##
==========================================
- Coverage 27.26% 27.23% -0.03%
==========================================
Files 1141 1141
Lines 25054 25057 +3
Branches 3624 3625 +1
==========================================
- Hits 6830 6824 -6
- Misses 17618 17627 +9
Partials 606 606
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4119?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ver/core/query/ServiceInstanceTopologyBuilder.java](https://codecov.io/gh/apache/skywalking/pull/4119/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcXVlcnkvU2VydmljZUluc3RhbmNlVG9wb2xvZ3lCdWlsZGVyLmphdmE=) | `0% <ø> (ø)` | :arrow_up: |
| [...ing/oap/server/library/client/grpc/GRPCClient.java](https://codecov.io/gh/apache/skywalking/pull/4119/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2dycGMvR1JQQ0NsaWVudC5qYXZh) | `0% <0%> (ø)` | :arrow_up: |
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/4119/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `85.71% <0%> (-3.18%)` | :arrow_down: |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/4119/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `0% <0%> (ø)` | :arrow_up: |
| [.../apm/agent/core/remote/StandardChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/4119/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1N0YW5kYXJkQ2hhbm5lbEJ1aWxkZXIuamF2YQ==) | `100% <100%> (ø)` | :arrow_up: |
| [...uster/plugin/kubernetes/KubernetesCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4119/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvS3ViZXJuZXRlc0Nvb3JkaW5hdG9yLmphdmE=) | `94.23% <100%> (+0.11%)` | :arrow_up: |
| [...apm/agent/core/remote/GRPCStreamServiceStatus.java](https://codecov.io/gh/apache/skywalking/pull/4119/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENTdHJlYW1TZXJ2aWNlU3RhdHVzLmphdmE=) | `29.16% <0%> (-25.01%)` | :arrow_down: |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/4119/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `60.36% <0%> (-0.91%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4119?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4119?src=pr&el=footer). Last update [ba192a9...2b9aef3](https://codecov.io/gh/apache/skywalking/pull/4119?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4119: Update JDK
compiling level to 8, and remove zip dist.
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4119: Update JDK compiling level to 8, and remove zip dist.
URL: https://github.com/apache/skywalking/pull/4119#issuecomment-568753962
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4119?src=pr&el=h1) Report
> Merging [#4119](https://codecov.io/gh/apache/skywalking/pull/4119?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/2b9aef370752c00ced4693dcd1404e058a54e2f3?src=pr&el=desc) will **decrease** coverage by `0.05%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4119?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4119 +/- ##
==========================================
- Coverage 27.23% 27.17% -0.06%
==========================================
Files 1141 1141
Lines 25057 25057
Branches 3625 3625
==========================================
- Hits 6824 6810 -14
- Misses 17627 17644 +17
+ Partials 606 603 -3
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4119?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../core/remote/ServiceAndEndpointRegisterClient.java](https://codecov.io/gh/apache/skywalking/pull/4119/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VBbmRFbmRwb2ludFJlZ2lzdGVyQ2xpZW50LmphdmE=) | `31.46% <0%> (-13.49%)` | :arrow_down: |
| [...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/4119/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==) | `73.77% <0%> (-3.28%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4119?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4119?src=pr&el=footer). Last update [2b9aef3...cef22ac](https://codecov.io/gh/apache/skywalking/pull/4119?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4119: Update JDK
compiling level to 8, and remove zip dist.
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4119: Update JDK compiling level to 8, and remove zip dist.
URL: https://github.com/apache/skywalking/pull/4119#issuecomment-568753962
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4119?src=pr&el=h1) Report
> Merging [#4119](https://codecov.io/gh/apache/skywalking/pull/4119?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9dcd3c74de5c90230f6fa59831d40c9be05df4c7?src=pr&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `16.66%`.
[](https://codecov.io/gh/apache/skywalking/pull/4119?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4119 +/- ##
==========================================
+ Coverage 27.26% 27.28% +0.02%
==========================================
Files 1140 1140
Lines 25024 25026 +2
Branches 3619 3620 +1
==========================================
+ Hits 6823 6829 +6
+ Misses 17595 17590 -5
- Partials 606 607 +1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4119?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ver/core/query/ServiceInstanceTopologyBuilder.java](https://codecov.io/gh/apache/skywalking/pull/4119/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcXVlcnkvU2VydmljZUluc3RhbmNlVG9wb2xvZ3lCdWlsZGVyLmphdmE=) | `0% <ø> (ø)` | :arrow_up: |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/4119/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `0% <0%> (ø)` | :arrow_up: |
| [...ing/oap/server/library/client/grpc/GRPCClient.java](https://codecov.io/gh/apache/skywalking/pull/4119/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2dycGMvR1JQQ0NsaWVudC5qYXZh) | `0% <0%> (ø)` | :arrow_up: |
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/4119/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `85.71% <0%> (-3.18%)` | :arrow_down: |
| [.../apm/agent/core/remote/StandardChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/4119/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1N0YW5kYXJkQ2hhbm5lbEJ1aWxkZXIuamF2YQ==) | `100% <100%> (ø)` | :arrow_up: |
| [...apm/agent/core/remote/GRPCStreamServiceStatus.java](https://codecov.io/gh/apache/skywalking/pull/4119/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENTdHJlYW1TZXJ2aWNlU3RhdHVzLmphdmE=) | `54.16% <0%> (+25%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4119?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4119?src=pr&el=footer). Last update [9dcd3c7...21e250f](https://codecov.io/gh/apache/skywalking/pull/4119?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services