[GitHub] [hadoop] toddlipcon commented on a change in pull request #597: HDFS-3246: pRead equivalent for direct read path

[GitBox <gi...@apache.org>]

toddlipcon commented on a change in pull request #597: HDFS-3246: pRead equivalent for direct read path
URL: https://github.com/apache/hadoop/pull/597#discussion_r269396288
 
 

 ##########
 File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/crypto/CryptoInputStream.java
 ##########
 @@ -341,17 +343,39 @@ public int read(long position, byte[] buffer, int offset, int length)
           "positioned read.");
     }
   }
+
+   /** Positioned read using ByteBuffers. It is thread-safe */
+  @Override
+  public int read(long position, final ByteBuffer buf)
+      throws IOException {
+    checkStream();
+    try {
+      int pos = buf.position();
 
 Review comment:
   nit: I think it would be good to rename this pos to 'bufPos' so it's clearer that it's referring to the position in the buffer and not the current position in the file

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org