You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/25 09:35:22 UTC

[GitHub] [flink] zentol opened a new pull request #14749: [FLINK-21123][fs] Bump beanutils to 1.9.4

zentol opened a new pull request #14749:
URL: https://github.com/apache/flink/pull/14749


   Bumps our 1.9.x beanutils dependencies to 1.9.4 .
   flink-fs-swift-hadoop (and it's bundled 1.8 dependency) are excluded from this change since we have no way to verify whether this has any functional impact on the filesystem. (aka, we have not a single test)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #14749: [FLINK-21123][fs] Bump beanutils to 1.9.4

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14749:
URL: https://github.com/apache/flink/pull/14749#issuecomment-766686218


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 718324dc3a3ad151ee2c40efd97b2bff3bc190c1 (Mon Jan 25 09:39:00 UTC 2021)
   
   **Warnings:**
    * **3 pom.xml files were touched**: Check for build and licensing issues.
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14749: [FLINK-21123][fs] Bump beanutils to 1.9.4

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14749:
URL: https://github.com/apache/flink/pull/14749#issuecomment-766686218


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 41d24cf8e001a4db55ceae9ccdfe9dee53e9faab (Fri May 28 08:06:50 UTC 2021)
   
   **Warnings:**
    * **3 pom.xml files were touched**: Check for build and licensing issues.
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol merged pull request #14749: [FLINK-21123][fs] Bump beanutils to 1.9.4

Posted by GitBox <gi...@apache.org>.
zentol merged pull request #14749:
URL: https://github.com/apache/flink/pull/14749


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol edited a comment on pull request #14749: [FLINK-21123][fs] Bump beanutils to 1.9.4

Posted by GitBox <gi...@apache.org>.
zentol edited a comment on pull request #14749:
URL: https://github.com/apache/flink/pull/14749#issuecomment-766851391


   The test failure is unlikely to be related (I can't see how that could affect things); I'll re-run the e2e tests to be sure.
   
   The core assumption I have is that the `flink-fs-swift-hadoop` filesystem currently works, by virtue of being excluded from bigger changes that the other filesystems underwent (like the hadoop3 migration) and not having been touched since it was merged, outside of some smaller security fixes.
   
   I'd argue that we should just drop `flink-fs-swift-hadoop` if we don't intend to actively maintain it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14749: [FLINK-21123][fs] Bump beanutils to 1.9.4

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14749:
URL: https://github.com/apache/flink/pull/14749#issuecomment-766689736






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] rmetzger commented on pull request #14749: [FLINK-21123][fs] Bump beanutils to 1.9.4

Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #14749:
URL: https://github.com/apache/flink/pull/14749#issuecomment-766794435






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14749: [FLINK-21123][fs] Bump beanutils to 1.9.4

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14749:
URL: https://github.com/apache/flink/pull/14749#issuecomment-766689736


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "718324dc3a3ad151ee2c40efd97b2bff3bc190c1",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12450",
       "triggerID" : "718324dc3a3ad151ee2c40efd97b2bff3bc190c1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "41d24cf8e001a4db55ceae9ccdfe9dee53e9faab",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "41d24cf8e001a4db55ceae9ccdfe9dee53e9faab",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 718324dc3a3ad151ee2c40efd97b2bff3bc190c1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12450) 
   * 41d24cf8e001a4db55ceae9ccdfe9dee53e9faab UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol commented on pull request #14749: [FLINK-21123][fs] Bump beanutils to 1.9.4

Posted by GitBox <gi...@apache.org>.
zentol commented on pull request #14749:
URL: https://github.com/apache/flink/pull/14749#issuecomment-766851391






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol edited a comment on pull request #14749: [FLINK-21123][fs] Bump beanutils to 1.9.4

Posted by GitBox <gi...@apache.org>.
zentol edited a comment on pull request #14749:
URL: https://github.com/apache/flink/pull/14749#issuecomment-766851391


   The test failure is unlikely to be related (I can't see how that could affect things); I'll re-run the e2e tests to be sure.
   
   The core assumption I have is that the `flink-fs-swift-hadoop` filesystem currently works, by virtue of being excluded from bigger changes that the other filesystems underwent (like the hadoop3 migration) and not having been touched since it was merged, outside of some smaller security fixes.
   
   I'd argue that we should just drop `flink-fs-swift-hadoop` if we don't intend to actively maintain it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #14749: [FLINK-21123][fs] Bump beanutils to 1.9.4

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14749:
URL: https://github.com/apache/flink/pull/14749#issuecomment-766689736


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "718324dc3a3ad151ee2c40efd97b2bff3bc190c1",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "718324dc3a3ad151ee2c40efd97b2bff3bc190c1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 718324dc3a3ad151ee2c40efd97b2bff3bc190c1 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14749: [FLINK-21123][fs] Bump beanutils to 1.9.4

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14749:
URL: https://github.com/apache/flink/pull/14749#issuecomment-766689736


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "718324dc3a3ad151ee2c40efd97b2bff3bc190c1",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12450",
       "triggerID" : "718324dc3a3ad151ee2c40efd97b2bff3bc190c1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 718324dc3a3ad151ee2c40efd97b2bff3bc190c1 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12450) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14749: [FLINK-21123][fs] Bump beanutils to 1.9.4

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14749:
URL: https://github.com/apache/flink/pull/14749#issuecomment-766689736


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "718324dc3a3ad151ee2c40efd97b2bff3bc190c1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12450",
       "triggerID" : "718324dc3a3ad151ee2c40efd97b2bff3bc190c1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "41d24cf8e001a4db55ceae9ccdfe9dee53e9faab",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12486",
       "triggerID" : "41d24cf8e001a4db55ceae9ccdfe9dee53e9faab",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 41d24cf8e001a4db55ceae9ccdfe9dee53e9faab Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12486) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14749: [FLINK-21123][fs] Bump beanutils to 1.9.4

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14749:
URL: https://github.com/apache/flink/pull/14749#issuecomment-766689736


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "718324dc3a3ad151ee2c40efd97b2bff3bc190c1",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12450",
       "triggerID" : "718324dc3a3ad151ee2c40efd97b2bff3bc190c1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 718324dc3a3ad151ee2c40efd97b2bff3bc190c1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12450) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14749: [FLINK-21123][fs] Bump beanutils to 1.9.4

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14749:
URL: https://github.com/apache/flink/pull/14749#issuecomment-766689736


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "718324dc3a3ad151ee2c40efd97b2bff3bc190c1",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12450",
       "triggerID" : "718324dc3a3ad151ee2c40efd97b2bff3bc190c1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "41d24cf8e001a4db55ceae9ccdfe9dee53e9faab",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12486",
       "triggerID" : "41d24cf8e001a4db55ceae9ccdfe9dee53e9faab",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 718324dc3a3ad151ee2c40efd97b2bff3bc190c1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12450) 
   * 41d24cf8e001a4db55ceae9ccdfe9dee53e9faab Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12486) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #14749: [FLINK-21123][fs] Bump beanutils to 1.9.4

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14749:
URL: https://github.com/apache/flink/pull/14749#issuecomment-766686218






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] rmetzger commented on pull request #14749: [FLINK-21123][fs] Bump beanutils to 1.9.4

Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #14749:
URL: https://github.com/apache/flink/pull/14749#issuecomment-766794435


   Thanks for opening this PR. It seems that the K8s e2e is not passing anymore due to this change.
   
   Also, I'm not sure what's more valuable: shipping a "vulnerability free" but maybe broken flink-fs-swift-hadoop implementation vs a vulnerable but maybe broken flink-fs-swift-hadoop impl. From a project perspective, we are having more trouble releasing a fat jar containing a vulnerable dependency than a potentially broken one.
   If this dependency bump would break the connector, we would at least learn that there's a user (and affected users could still use the 1.12 release of the connector impl while we fix it).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] rmetzger commented on pull request #14749: [FLINK-21123][fs] Bump beanutils to 1.9.4

Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #14749:
URL: https://github.com/apache/flink/pull/14749#issuecomment-766887772


   > The test failure is unlikely to be related (I can't see how that could affect things); I'll re-run the e2e tests to be sure.
   
   But the same failure occurred in your personal CI as well: https://dev.azure.com/chesnay/flink/_build/results?buildId=685&view=results
   
   Dropping it: I haven't any significant user@ thread asking something about the File system.
   It was contributed in 2018, and a quick "git blame" on the module doesn't reveal any more changes to it = no new contributions.
   
   Are you, or shall I start a discussion for dropping it?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol commented on pull request #14749: [FLINK-21123][fs] Bump beanutils to 1.9.4

Posted by GitBox <gi...@apache.org>.
zentol commented on pull request #14749:
URL: https://github.com/apache/flink/pull/14749#issuecomment-766851391


   The test failure is unlikely to be related (I can't see how that could affect things); I'll re-run the e2e tests to be sure.
   
   The core assumption I have is that the `flink-fs-swift-hadoop` filesystem currently works, by virtue of being excluded from bigger changes that the other filesystems underwent (like the hadoop3 migration) and not having been touched since it was merged, outside of some smaller security fixes.
   
   I'd argue that we should just drop flink-fs-swift-hadoop if we don't intend to actively maintain it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol commented on pull request #14749: [FLINK-21123][fs] Bump beanutils to 1.9.4

Posted by GitBox <gi...@apache.org>.
zentol commented on pull request #14749:
URL: https://github.com/apache/flink/pull/14749#issuecomment-767103094


   > But the same failure occurred in your personal CI as well
   
   The branch was just horrendously out-dated and no longer compatible with the docker files.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org