You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2019/12/27 10:46:43 UTC
[GitHub] [kylin] ChangjiGuo opened a new pull request #1026: delete
/execute_output metadata when deleting a job
ChangjiGuo opened a new pull request #1026: delete /execute_output metadata when deleting a job
URL: https://github.com/apache/kylin/pull/1026
Delete both /execute and /execute_output metadata when deleting a job.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] asf-ci commented on issue #1026: delete /execute_output
metadata at the same time when deleting a job
Posted by GitBox <gi...@apache.org>.
asf-ci commented on issue #1026: delete /execute_output metadata at the same time when deleting a job
URL: https://github.com/apache/kylin/pull/1026#issuecomment-569616514
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] codecov-io edited a comment on issue #1026: delete
/execute_output metadata at the same time when deleting a job
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1026: delete /execute_output metadata at the same time when deleting a job
URL: https://github.com/apache/kylin/pull/1026#issuecomment-569658483
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1026?src=pr&el=h1) Report
> Merging [#1026](https://codecov.io/gh/apache/kylin/pull/1026?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/6e4e456f701f1bdc5d5be7e0f738dae65215a782?src=pr&el=desc) will **decrease** coverage by `0.1%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/kylin/pull/1026?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1026 +/- ##
===========================================
- Coverage 25.11% 25% -0.11%
- Complexity 6178 6180 +2
===========================================
Files 1433 1437 +4
Lines 87270 87653 +383
Branches 12218 12252 +34
===========================================
+ Hits 21917 21920 +3
- Misses 63205 63581 +376
- Partials 2148 2152 +4
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1026?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...n/java/org/apache/kylin/job/dao/ExecutableDao.java](https://codecov.io/gh/apache/kylin/pull/1026/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9kYW8vRXhlY3V0YWJsZURhby5qYXZh) | `27.51% <0%> (-1.8%)` | `24 <0> (ø)` | |
| [...core/storage/columnar/GeneralColumnDataReader.java](https://codecov.io/gh/apache/kylin/pull/1026/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvR2VuZXJhbENvbHVtbkRhdGFSZWFkZXIuamF2YQ==) | `89.47% <0%> (-5.27%)` | `6% <0%> (-1%)` | |
| [.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/1026/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=) | `63.84% <0%> (-2.31%)` | `0% <0%> (ø)` | |
| [...in/java/org/apache/kylin/query/util/QueryUtil.java](https://codecov.io/gh/apache/kylin/pull/1026/diff?src=pr&el=tree#diff-cXVlcnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3F1ZXJ5L3V0aWwvUXVlcnlVdGlsLmphdmE=) | `62.88% <0%> (-2.01%)` | `26% <0%> (ø)` | |
| [.../java/org/apache/kylin/common/util/HadoopUtil.java](https://codecov.io/gh/apache/kylin/pull/1026/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi91dGlsL0hhZG9vcFV0aWwuamF2YQ==) | `14.56% <0%> (-1.23%)` | `10% <0%> (ø)` | |
| [.../apache/kylin/metadata/model/DataModelManager.java](https://codecov.io/gh/apache/kylin/pull/1026/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvbW9kZWwvRGF0YU1vZGVsTWFuYWdlci5qYXZh) | `30.7% <0%> (-1.12%)` | `11% <0%> (ø)` | |
| [...va/org/apache/kylin/source/hive/HiveInputBase.java](https://codecov.io/gh/apache/kylin/pull/1026/diff?src=pr&el=tree#diff-c291cmNlLWhpdmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9oaXZlL0hpdmVJbnB1dEJhc2UuamF2YQ==) | `6.69% <0%> (-1.07%)` | `4% <0%> (ø)` | |
| [...eam/core/storage/columnar/FragmentFilesMerger.java](https://codecov.io/gh/apache/kylin/pull/1026/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvRnJhZ21lbnRGaWxlc01lcmdlci5qYXZh) | `96.02% <0%> (-0.53%)` | `30% <0%> (ø)` | |
| [.../java/org/apache/kylin/common/KylinConfigBase.java](https://codecov.io/gh/apache/kylin/pull/1026/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Jhc2UuamF2YQ==) | `12.36% <0%> (-0.5%)` | `44% <0%> (ø)` | |
| [...org/apache/kylin/metadata/model/DataModelDesc.java](https://codecov.io/gh/apache/kylin/pull/1026/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvbW9kZWwvRGF0YU1vZGVsRGVzYy5qYXZh) | `59.78% <0%> (-0.11%)` | `73% <0%> (+1%)` | |
| ... and [20 more](https://codecov.io/gh/apache/kylin/pull/1026/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1026?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1026?src=pr&el=footer). Last update [6e4e456...557b5dc](https://codecov.io/gh/apache/kylin/pull/1026?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] codecov-io edited a comment on issue #1026: delete
/execute_output metadata at the same time when deleting a job
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1026: delete /execute_output metadata at the same time when deleting a job
URL: https://github.com/apache/kylin/pull/1026#issuecomment-569658483
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1026?src=pr&el=h1) Report
> Merging [#1026](https://codecov.io/gh/apache/kylin/pull/1026?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/6e4e456f701f1bdc5d5be7e0f738dae65215a782?src=pr&el=desc) will **decrease** coverage by `0.1%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/kylin/pull/1026?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1026 +/- ##
===========================================
- Coverage 25.11% 25% -0.11%
Complexity 6178 6178
===========================================
Files 1433 1437 +4
Lines 87270 87634 +364
Branches 12218 12250 +32
===========================================
Hits 21917 21917
- Misses 63205 63566 +361
- Partials 2148 2151 +3
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1026?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...n/java/org/apache/kylin/job/dao/ExecutableDao.java](https://codecov.io/gh/apache/kylin/pull/1026/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9kYW8vRXhlY3V0YWJsZURhby5qYXZh) | `27.51% <0%> (-1.8%)` | `24 <0> (ø)` | |
| [...core/storage/columnar/GeneralColumnDataReader.java](https://codecov.io/gh/apache/kylin/pull/1026/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvR2VuZXJhbENvbHVtbkRhdGFSZWFkZXIuamF2YQ==) | `89.47% <0%> (-5.27%)` | `6% <0%> (-1%)` | |
| [.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/1026/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=) | `63.84% <0%> (-2.31%)` | `0% <0%> (ø)` | |
| [.../java/org/apache/kylin/common/util/HadoopUtil.java](https://codecov.io/gh/apache/kylin/pull/1026/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi91dGlsL0hhZG9vcFV0aWwuamF2YQ==) | `14.56% <0%> (-1.23%)` | `10% <0%> (ø)` | |
| [...va/org/apache/kylin/source/hive/HiveInputBase.java](https://codecov.io/gh/apache/kylin/pull/1026/diff?src=pr&el=tree#diff-c291cmNlLWhpdmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9oaXZlL0hpdmVJbnB1dEJhc2UuamF2YQ==) | `6.69% <0%> (-1.07%)` | `4% <0%> (ø)` | |
| [...a/org/apache/kylin/dict/Number2BytesConverter.java](https://codecov.io/gh/apache/kylin/pull/1026/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L051bWJlcjJCeXRlc0NvbnZlcnRlci5qYXZh) | `81.74% <0%> (-0.8%)` | `17% <0%> (-1%)` | |
| [...eam/core/storage/columnar/FragmentFilesMerger.java](https://codecov.io/gh/apache/kylin/pull/1026/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvRnJhZ21lbnRGaWxlc01lcmdlci5qYXZh) | `96.02% <0%> (-0.53%)` | `30% <0%> (ø)` | |
| [.../java/org/apache/kylin/common/KylinConfigBase.java](https://codecov.io/gh/apache/kylin/pull/1026/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Jhc2UuamF2YQ==) | `12.36% <0%> (-0.5%)` | `44% <0%> (ø)` | |
| [...rg/apache/kylin/source/hive/BeelineHiveClient.java](https://codecov.io/gh/apache/kylin/pull/1026/diff?src=pr&el=tree#diff-c291cmNlLWhpdmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9oaXZlL0JlZWxpbmVIaXZlQ2xpZW50LmphdmE=) | `3.84% <0%> (-0.03%)` | `5% <0%> (ø)` | |
| [...che/kylin/engine/mr/streaming/RowRecordReader.java](https://codecov.io/gh/apache/kylin/pull/1026/diff?src=pr&el=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvc3RyZWFtaW5nL1Jvd1JlY29yZFJlYWRlci5qYXZh) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
| ... and [15 more](https://codecov.io/gh/apache/kylin/pull/1026/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1026?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1026?src=pr&el=footer). Last update [6e4e456...48365dd](https://codecov.io/gh/apache/kylin/pull/1026?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] asf-ci commented on issue #1026: delete /execute_output
metadata at the same time when deleting a job
Posted by GitBox <gi...@apache.org>.
asf-ci commented on issue #1026: delete /execute_output metadata at the same time when deleting a job
URL: https://github.com/apache/kylin/pull/1026#issuecomment-569616515
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] ChangjiGuo commented on issue #1026: delete /execute_output
metadata at the same time when deleting a job
Posted by GitBox <gi...@apache.org>.
ChangjiGuo commented on issue #1026: delete /execute_output metadata at the same time when deleting a job
URL: https://github.com/apache/kylin/pull/1026#issuecomment-569637531
Hi @nichunen
I agree with your doubt. Do you think it is necessary to delete /execute_output?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] codecov-io commented on issue #1026: delete /execute_output
metadata at the same time when deleting a job
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1026: delete /execute_output metadata at the same time when deleting a job
URL: https://github.com/apache/kylin/pull/1026#issuecomment-569658483
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1026?src=pr&el=h1) Report
> Merging [#1026](https://codecov.io/gh/apache/kylin/pull/1026?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/4c8380549e10befd5cfb266eff6db9973582061f?src=pr&el=desc) will **decrease** coverage by `0.04%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/kylin/pull/1026?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1026 +/- ##
===========================================
- Coverage 25.05% 25% -0.05%
+ Complexity 6179 6178 -1
===========================================
Files 1434 1437 +3
Lines 87457 87634 +177
Branches 12234 12250 +16
===========================================
+ Hits 21913 21915 +2
- Misses 63396 63568 +172
- Partials 2148 2151 +3
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1026?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...n/java/org/apache/kylin/job/dao/ExecutableDao.java](https://codecov.io/gh/apache/kylin/pull/1026/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9kYW8vRXhlY3V0YWJsZURhby5qYXZh) | `27.51% <0%> (-1.8%)` | `24 <0> (ø)` | |
| [...va/org/apache/kylin/source/hive/HiveInputBase.java](https://codecov.io/gh/apache/kylin/pull/1026/diff?src=pr&el=tree#diff-c291cmNlLWhpdmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9oaXZlL0hpdmVJbnB1dEJhc2UuamF2YQ==) | `6.69% <0%> (-1.07%)` | `4% <0%> (ø)` | |
| [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/1026/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `69.3% <0%> (-0.92%)` | `7% <0%> (ø)` | |
| [...a/org/apache/kylin/dict/Number2BytesConverter.java](https://codecov.io/gh/apache/kylin/pull/1026/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L051bWJlcjJCeXRlc0NvbnZlcnRlci5qYXZh) | `81.74% <0%> (-0.8%)` | `17% <0%> (-1%)` | |
| [...eam/core/storage/columnar/FragmentFilesMerger.java](https://codecov.io/gh/apache/kylin/pull/1026/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvRnJhZ21lbnRGaWxlc01lcmdlci5qYXZh) | `96.02% <0%> (-0.53%)` | `30% <0%> (ø)` | |
| [.../java/org/apache/kylin/common/KylinConfigBase.java](https://codecov.io/gh/apache/kylin/pull/1026/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Jhc2UuamF2YQ==) | `12.36% <0%> (-0.48%)` | `44% <0%> (ø)` | |
| [...rg/apache/kylin/source/hive/BeelineHiveClient.java](https://codecov.io/gh/apache/kylin/pull/1026/diff?src=pr&el=tree#diff-c291cmNlLWhpdmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9oaXZlL0JlZWxpbmVIaXZlQ2xpZW50LmphdmE=) | `3.84% <0%> (-0.03%)` | `5% <0%> (ø)` | |
| [...che/kylin/engine/mr/streaming/RowRecordReader.java](https://codecov.io/gh/apache/kylin/pull/1026/diff?src=pr&el=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvc3RyZWFtaW5nL1Jvd1JlY29yZFJlYWRlci5qYXZh) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
| [...ache/kylin/query/adhoc/PushDownRunnerJdbcImpl.java](https://codecov.io/gh/apache/kylin/pull/1026/diff?src=pr&el=tree#diff-cXVlcnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3F1ZXJ5L2FkaG9jL1B1c2hEb3duUnVubmVySmRiY0ltcGwuamF2YQ==) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
| [...st/controller/ServiceDiscoveryStateController.java](https://codecov.io/gh/apache/kylin/pull/1026/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvY29udHJvbGxlci9TZXJ2aWNlRGlzY292ZXJ5U3RhdGVDb250cm9sbGVyLmphdmE=) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
| ... and [8 more](https://codecov.io/gh/apache/kylin/pull/1026/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1026?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1026?src=pr&el=footer). Last update [4c83805...7d26445](https://codecov.io/gh/apache/kylin/pull/1026?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] ChangjiGuo commented on issue #1026: delete /execute_output
metadata at the same time when deleting a job
Posted by GitBox <gi...@apache.org>.
ChangjiGuo commented on issue #1026: delete /execute_output metadata at the same time when deleting a job
URL: https://github.com/apache/kylin/pull/1026#issuecomment-569638030
How about adding a verification in the catch statement?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] coveralls edited a comment on issue #1026: delete
/execute_output metadata at the same time when deleting a job
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #1026: delete /execute_output metadata at the same time when deleting a job
URL: https://github.com/apache/kylin/pull/1026#issuecomment-569659337
## Pull Request Test Coverage Report for [Build 5462](https://coveralls.io/builds/27844295)
* **0** of **14** **(0.0%)** changed or added relevant lines in **1** file are covered.
* **511** unchanged lines in **11** files lost coverage.
* Overall coverage decreased (**-0.05%**) to **27.468%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [core-job/src/main/java/org/apache/kylin/job/dao/ExecutableDao.java](https://coveralls.io/builds/27844295/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2Fdao%2FExecutableDao.java#L381) | 0 | 14 | 0.0%
<!-- | **Total:** | **0** | **14** | **0.0%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/ColumnarStoreMetricsDesc.java](https://coveralls.io/builds/27844295/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2Fcolumnar%2FColumnarStoreMetricsDesc.java#L80) | 3 | 69.57% |
| [stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/FragmentFilesMerger.java](https://coveralls.io/builds/27844295/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2Fcolumnar%2FFragmentFilesMerger.java#L341) | 4 | 97.73% |
| [query/src/main/java/org/apache/kylin/query/adhoc/JdbcPushDownConnectionManager.java](https://coveralls.io/builds/27844295/source?filename=query%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fquery%2Fadhoc%2FJdbcPushDownConnectionManager.java#L38) | 8 | 0.0% |
| [query/src/main/java/org/apache/kylin/query/util/PushDownUtil.java](https://coveralls.io/builds/27844295/source?filename=query%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fquery%2Futil%2FPushDownUtil.java#L66) | 13 | 75.68% |
| [server-base/src/main/java/org/apache/kylin/rest/controller/ServiceDiscoveryStateController.java](https://coveralls.io/builds/27844295/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fcontroller%2FServiceDiscoveryStateController.java#L66) | 25 | 0.0% |
| [engine-mr/src/main/java/org/apache/kylin/engine/mr/streaming/RowRecordReader.java](https://coveralls.io/builds/27844295/source?filename=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2Fstreaming%2FRowRecordReader.java#L131) | 38 | 0.0% |
| [source-hive/src/main/java/org/apache/kylin/source/hive/BeelineHiveClient.java](https://coveralls.io/builds/27844295/source?filename=source-hive%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fhive%2FBeelineHiveClient.java#L85) | 50 | 5.13% |
| [engine-spark/src/main/java/org/apache/kylin/engine/spark/SparkExecutable.java](https://coveralls.io/builds/27844295/source?filename=engine-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fspark%2FSparkExecutable.java#L255) | 59 | 0.0% |
| [query/src/main/java/org/apache/kylin/query/adhoc/PushDownRunnerJdbcImpl.java](https://coveralls.io/builds/27844295/source?filename=query%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fquery%2Fadhoc%2FPushDownRunnerJdbcImpl.java#L79) | 81 | 0.0% |
| [core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java](https://coveralls.io/builds/27844295/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2FKylinConfigBase.java#L1852) | 108 | 13.6% |
<!-- | **Total:** | **511** | | -->
| Totals | [](https://coveralls.io/builds/27844295) |
| :-- | --: |
| Change from base [Build 5457](https://coveralls.io/builds/27821714): | -0.05% |
| Covered Lines: | 24071 |
| Relevant Lines: | 87634 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] coveralls commented on issue #1026: delete /execute_output
metadata at the same time when deleting a job
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #1026: delete /execute_output metadata at the same time when deleting a job
URL: https://github.com/apache/kylin/pull/1026#issuecomment-569659337
## Pull Request Test Coverage Report for [Build 5461](https://coveralls.io/builds/27843836)
* **0** of **14** **(0.0%)** changed or added relevant lines in **1** file are covered.
* **516** unchanged lines in **12** files lost coverage.
* Overall coverage decreased (**-0.05%**) to **27.465%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [core-job/src/main/java/org/apache/kylin/job/dao/ExecutableDao.java](https://coveralls.io/builds/27843836/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2Fdao%2FExecutableDao.java#L383) | 0 | 14 | 0.0%
<!-- | **Total:** | **0** | **14** | **0.0%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/ColumnarStoreMetricsDesc.java](https://coveralls.io/builds/27843836/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2Fcolumnar%2FColumnarStoreMetricsDesc.java#L80) | 3 | 69.57% |
| [stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/FragmentFilesMerger.java](https://coveralls.io/builds/27843836/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2Fcolumnar%2FFragmentFilesMerger.java#L341) | 4 | 97.73% |
| [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/27843836/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L439) | 5 | 77.81% |
| [query/src/main/java/org/apache/kylin/query/adhoc/JdbcPushDownConnectionManager.java](https://coveralls.io/builds/27843836/source?filename=query%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fquery%2Fadhoc%2FJdbcPushDownConnectionManager.java#L38) | 8 | 0.0% |
| [query/src/main/java/org/apache/kylin/query/util/PushDownUtil.java](https://coveralls.io/builds/27843836/source?filename=query%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fquery%2Futil%2FPushDownUtil.java#L66) | 13 | 75.68% |
| [server-base/src/main/java/org/apache/kylin/rest/controller/ServiceDiscoveryStateController.java](https://coveralls.io/builds/27843836/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fcontroller%2FServiceDiscoveryStateController.java#L66) | 25 | 0.0% |
| [engine-mr/src/main/java/org/apache/kylin/engine/mr/streaming/RowRecordReader.java](https://coveralls.io/builds/27843836/source?filename=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2Fstreaming%2FRowRecordReader.java#L131) | 38 | 0.0% |
| [source-hive/src/main/java/org/apache/kylin/source/hive/BeelineHiveClient.java](https://coveralls.io/builds/27843836/source?filename=source-hive%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fhive%2FBeelineHiveClient.java#L85) | 50 | 5.13% |
| [engine-spark/src/main/java/org/apache/kylin/engine/spark/SparkExecutable.java](https://coveralls.io/builds/27843836/source?filename=engine-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fspark%2FSparkExecutable.java#L255) | 59 | 0.0% |
| [query/src/main/java/org/apache/kylin/query/adhoc/PushDownRunnerJdbcImpl.java](https://coveralls.io/builds/27843836/source?filename=query%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fquery%2Fadhoc%2FPushDownRunnerJdbcImpl.java#L79) | 81 | 0.0% |
<!-- | **Total:** | **516** | | -->
| Totals | [](https://coveralls.io/builds/27843836) |
| :-- | --: |
| Change from base [Build 5457](https://coveralls.io/builds/27821714): | -0.05% |
| Covered Lines: | 24069 |
| Relevant Lines: | 87634 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] coveralls edited a comment on issue #1026: delete
/execute_output metadata at the same time when deleting a job
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #1026: delete /execute_output metadata at the same time when deleting a job
URL: https://github.com/apache/kylin/pull/1026#issuecomment-569659337
## Pull Request Test Coverage Report for [Build 5480](https://coveralls.io/builds/27893902)
* **0** of **14** **(0.0%)** changed or added relevant lines in **1** file are covered.
* **1** unchanged line in **1** file lost coverage.
* Overall coverage decreased (**-0.003%**) to **27.466%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [core-job/src/main/java/org/apache/kylin/job/dao/ExecutableDao.java](https://coveralls.io/builds/27893902/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2Fdao%2FExecutableDao.java#L381) | 0 | 14 | 0.0%
<!-- | **Total:** | **0** | **14** | **0.0%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://coveralls.io/builds/27893902/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2Flookup%2Fcache%2FRocksDBLookupTable.java#L62) | 1 | 81.08% |
<!-- | **Total:** | **1** | | -->
| Totals | [](https://coveralls.io/builds/27893902) |
| :-- | --: |
| Change from base [Build 5479](https://coveralls.io/builds/27893739): | -0.003% |
| Covered Lines: | 24075 |
| Relevant Lines: | 87653 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] ChangjiGuo commented on issue #1026: delete /execute_output
metadata at the same time when deleting a job
Posted by GitBox <gi...@apache.org>.
ChangjiGuo commented on issue #1026: delete /execute_output metadata at the same time when deleting a job
URL: https://github.com/apache/kylin/pull/1026#issuecomment-569651906
Or delete output separately?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] ChangjiGuo closed pull request #1026: delete
/execute_output metadata at the same time when deleting a job
Posted by GitBox <gi...@apache.org>.
ChangjiGuo closed pull request #1026: delete /execute_output metadata at the same time when deleting a job
URL: https://github.com/apache/kylin/pull/1026
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] nichunen commented on issue #1026: delete /execute_output
metadata at the same time when deleting a job
Posted by GitBox <gi...@apache.org>.
nichunen commented on issue #1026: delete /execute_output metadata at the same time when deleting a job
URL: https://github.com/apache/kylin/pull/1026#issuecomment-569616496
@ChangjiGuo
Hi, I think your point of this PR is right, job's tasks' should also be deleted once the job is deleted (they will be deleted by MetadataCleanupJob).
But I doubt the code change will also bring instability of the job deleting operation. Because before this change, dropping a job only needs one time of metadata deleting, but after this change, it needs n+1 times(n is the number of tasks). If one task failed to be deleted, an exception will be thrown which indicates the deletion is failed, but actually, the job's metadata has been deleted.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services