You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "Sergey Shelukhin (JIRA)" <ji...@apache.org> on 2018/02/08 22:37:00 UTC
[jira] [Commented] (HIVE-18492) Wrong argument in the
WorkloadManager.resetAndQueryKill()
[ https://issues.apache.org/jira/browse/HIVE-18492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16357666#comment-16357666 ]
Sergey Shelukhin commented on HIVE-18492:
-----------------------------------------
Modified the patch to use ==, since we should never have more than one object for the same session.
[~prasanth_j] does that make sense?
> Wrong argument in the WorkloadManager.resetAndQueryKill()
> ---------------------------------------------------------
>
> Key: HIVE-18492
> URL: https://issues.apache.org/jira/browse/HIVE-18492
> Project: Hive
> Issue Type: Bug
> Reporter: Oleg Danilov
> Assignee: Oleg Danilov
> Priority: Trivial
> Attachments: HIVE-18492.03.patch, HIVE-18492.04.patch, HIVE-18492.2.patch, HIVE-18492.patch
>
>
> Caused by HIVE-18088, [~prasanth_j], could you please check this?
> {code:java}
> private void resetAndQueueKill(Map<WmTezSession, KillQueryContext> toKillQuery,
> KillQueryContext killQueryContext, Map<WmTezSession, GetRequest> toReuse) {
> WmTezSession toKill = killQueryContext.session;
> ...
> if (poolState != null) {
> poolState.getSessions().remove(toKill);
> poolState.getInitializingSessions().remove(toKill);
> ...
> {code}
> getInitializingSessions() returns List of SessionInitContext, so toKill definitely can't be in this list and therefore no needs to remove it.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)