You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Pradeep Kamath (JIRA)" <ji...@apache.org> on 2010/06/03 06:30:10 UTC
[jira] Created: (PIG-1433) pig should create success file if
mapreduce.fileoutputcommitter.marksuccessfuljobs is true
pig should create success file if mapreduce.fileoutputcommitter.marksuccessfuljobs is true
------------------------------------------------------------------------------------------
Key: PIG-1433
URL: https://issues.apache.org/jira/browse/PIG-1433
Project: Pig
Issue Type: Bug
Affects Versions: 0.8.0
Reporter: Pradeep Kamath
Assignee: Pradeep Kamath
Fix For: 0.8.0
pig should create success file if mapreduce.fileoutputcommitter.marksuccessfuljobs is true
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1433) pig should create success file if
mapreduce.fileoutputcommitter.marksuccessfuljobs is true
Posted by "Gianmarco De Francisci Morales (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12875321#action_12875321 ]
Gianmarco De Francisci Morales commented on PIG-1433:
-----------------------------------------------------
Just for the sake of clean code, constant interface is an anti-pattern.
http://en.wikipedia.org/wiki/Constant_interface
Public final instance controlled (no instance) classes are better for this purpose.
> pig should create success file if mapreduce.fileoutputcommitter.marksuccessfuljobs is true
> ------------------------------------------------------------------------------------------
>
> Key: PIG-1433
> URL: https://issues.apache.org/jira/browse/PIG-1433
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.8.0
> Reporter: Pradeep Kamath
> Assignee: Pradeep Kamath
> Fix For: 0.8.0
>
> Attachments: PIG-1433.patch
>
>
> pig should create success file if mapreduce.fileoutputcommitter.marksuccessfuljobs is true
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1433) pig should create success file if
mapreduce.fileoutputcommitter.marksuccessfuljobs is true
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12875639#action_12875639 ]
Hadoop QA commented on PIG-1433:
--------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12446222/PIG-1433.patch
against trunk revision 951229.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
-1 patch. The patch command could not apply the patch.
Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/330/console
This message is automatically generated.
> pig should create success file if mapreduce.fileoutputcommitter.marksuccessfuljobs is true
> ------------------------------------------------------------------------------------------
>
> Key: PIG-1433
> URL: https://issues.apache.org/jira/browse/PIG-1433
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.8.0
> Reporter: Pradeep Kamath
> Assignee: Pradeep Kamath
> Fix For: 0.8.0
>
> Attachments: PIG-1433.patch
>
>
> pig should create success file if mapreduce.fileoutputcommitter.marksuccessfuljobs is true
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1433) pig should create success file if
mapreduce.fileoutputcommitter.marksuccessfuljobs is true
Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12875319#action_12875319 ]
Ashutosh Chauhan commented on PIG-1433:
---------------------------------------
+1 for the commit. couple of notes for future:
* Since this is related to Hadoop property. We should consider this removing from Pig codebase when MAPREDUCE-1447 and MAPREDUCE-947 are fixed.
* We have lot of constant strings in our codebase. For the sake of clean code, we shall put all of those public static final string in one top level interface called Constants. This should be part of seperate clean-up code jira.
> pig should create success file if mapreduce.fileoutputcommitter.marksuccessfuljobs is true
> ------------------------------------------------------------------------------------------
>
> Key: PIG-1433
> URL: https://issues.apache.org/jira/browse/PIG-1433
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.8.0
> Reporter: Pradeep Kamath
> Assignee: Pradeep Kamath
> Fix For: 0.8.0
>
> Attachments: PIG-1433.patch
>
>
> pig should create success file if mapreduce.fileoutputcommitter.marksuccessfuljobs is true
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1433) pig should create success file if
mapreduce.fileoutputcommitter.marksuccessfuljobs is true
Posted by "Pradeep Kamath (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pradeep Kamath updated PIG-1433:
--------------------------------
Status: Resolved (was: Patch Available)
Hadoop Flags: [Reviewed]
Fix Version/s: 0.7.0
Resolution: Fixed
> pig should create success file if mapreduce.fileoutputcommitter.marksuccessfuljobs is true
> ------------------------------------------------------------------------------------------
>
> Key: PIG-1433
> URL: https://issues.apache.org/jira/browse/PIG-1433
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.8.0
> Reporter: Pradeep Kamath
> Assignee: Pradeep Kamath
> Fix For: 0.8.0, 0.7.0
>
> Attachments: PIG-1433-for-branch-0.7.patch, PIG-1433.patch
>
>
> pig should create success file if mapreduce.fileoutputcommitter.marksuccessfuljobs is true
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1433) pig should create success file if
mapreduce.fileoutputcommitter.marksuccessfuljobs is true
Posted by "Pradeep Kamath (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pradeep Kamath updated PIG-1433:
--------------------------------
Status: Patch Available (was: Open)
> pig should create success file if mapreduce.fileoutputcommitter.marksuccessfuljobs is true
> ------------------------------------------------------------------------------------------
>
> Key: PIG-1433
> URL: https://issues.apache.org/jira/browse/PIG-1433
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.8.0
> Reporter: Pradeep Kamath
> Assignee: Pradeep Kamath
> Fix For: 0.8.0
>
> Attachments: PIG-1433.patch
>
>
> pig should create success file if mapreduce.fileoutputcommitter.marksuccessfuljobs is true
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1433) pig should create success file if
mapreduce.fileoutputcommitter.marksuccessfuljobs is true
Posted by "Pradeep Kamath (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pradeep Kamath updated PIG-1433:
--------------------------------
Attachment: PIG-1433.patch
Attached patch addresses the issue in MapReduceLauncher by creating an _SUCCESS file for stores which are part of successful jobs if the property is set in the job.
> pig should create success file if mapreduce.fileoutputcommitter.marksuccessfuljobs is true
> ------------------------------------------------------------------------------------------
>
> Key: PIG-1433
> URL: https://issues.apache.org/jira/browse/PIG-1433
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.8.0
> Reporter: Pradeep Kamath
> Assignee: Pradeep Kamath
> Fix For: 0.8.0
>
> Attachments: PIG-1433.patch
>
>
> pig should create success file if mapreduce.fileoutputcommitter.marksuccessfuljobs is true
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1433) pig should create success file if
mapreduce.fileoutputcommitter.marksuccessfuljobs is true
Posted by "Pradeep Kamath (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pradeep Kamath updated PIG-1433:
--------------------------------
Attachment: PIG-1433-for-branch-0.7.patch
The original patch was committed to trunk. It did not apply for branch-0.7 - so I have attached a new patch with minor modifications for branch-0.7. This latter patch was committed to branch-0.7
> pig should create success file if mapreduce.fileoutputcommitter.marksuccessfuljobs is true
> ------------------------------------------------------------------------------------------
>
> Key: PIG-1433
> URL: https://issues.apache.org/jira/browse/PIG-1433
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.8.0
> Reporter: Pradeep Kamath
> Assignee: Pradeep Kamath
> Fix For: 0.7.0, 0.8.0
>
> Attachments: PIG-1433-for-branch-0.7.patch, PIG-1433.patch
>
>
> pig should create success file if mapreduce.fileoutputcommitter.marksuccessfuljobs is true
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1433) pig should create success file if
mapreduce.fileoutputcommitter.marksuccessfuljobs is true
Posted by "Pradeep Kamath (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12875292#action_12875292 ]
Pradeep Kamath commented on PIG-1433:
-------------------------------------
Hudson seems to be unresponsive - I ran unit tests locally and they completed successfully. The "test-patch" ant target also came back successfully except for a html page change in the release audit warnings which can be ignored.
Patch is ready for review.
> pig should create success file if mapreduce.fileoutputcommitter.marksuccessfuljobs is true
> ------------------------------------------------------------------------------------------
>
> Key: PIG-1433
> URL: https://issues.apache.org/jira/browse/PIG-1433
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.8.0
> Reporter: Pradeep Kamath
> Assignee: Pradeep Kamath
> Fix For: 0.8.0
>
> Attachments: PIG-1433.patch
>
>
> pig should create success file if mapreduce.fileoutputcommitter.marksuccessfuljobs is true
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1433) pig should create success file if
mapreduce.fileoutputcommitter.marksuccessfuljobs is true
Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12875326#action_12875326 ]
Ashutosh Chauhan commented on PIG-1433:
---------------------------------------
My point was to have all constant strings in one place instead of each class having some of them It could be either interface or class. If interface is considered anti-pattern, doing it in class is fine too.
> pig should create success file if mapreduce.fileoutputcommitter.marksuccessfuljobs is true
> ------------------------------------------------------------------------------------------
>
> Key: PIG-1433
> URL: https://issues.apache.org/jira/browse/PIG-1433
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.8.0
> Reporter: Pradeep Kamath
> Assignee: Pradeep Kamath
> Fix For: 0.8.0
>
> Attachments: PIG-1433.patch
>
>
> pig should create success file if mapreduce.fileoutputcommitter.marksuccessfuljobs is true
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.