You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@libcloud.apache.org by "Tomaz Muraus (JIRA)" <ji...@apache.org> on 2013/04/23 21:53:16 UTC

[dev] [jira] [Commented] (LIBCLOUD-320) vCloud 5.1 vm memory Support / Repatch

    [ https://issues.apache.org/jira/browse/LIBCLOUD-320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13639489#comment-13639489 ] 

Tomaz Muraus commented on LIBCLOUD-320:
---------------------------------------

Ugh, yeah, my bad.

Patch didn't apply cleanly and it looks like I've copied a wrong line and there was no test to catch this.

I will merge this patch into trunk as soon as possible. I would also appreciate if you can add a test case which catches this.

Thanks
                
> vCloud 5.1 vm memory Support  / Repatch
> ---------------------------------------
>
>                 Key: LIBCLOUD-320
>                 URL: https://issues.apache.org/jira/browse/LIBCLOUD-320
>             Project: Libcloud
>          Issue Type: Bug
>          Components: Compute
>    Affects Versions: 0.12.3
>            Reporter: Trevor Powell (RMS)
>              Labels: vcloud
>         Attachments: libcloud-320.patch
>
>
> In LIBCLOUD-314 a patch was submitted for memory support for VCD 5.1 .
> It seems the patch that was submitted was not correctly inserted into the code base.
> Submitted patch: https://issues.apache.org/jira/secure/attachment/12578585/vcd5_1.patch
> Patch in the code base: https://svn.apache.org/viewvc/libcloud/trunk/libcloud/compute/drivers/vcloud.py?r1=1467555&r2=1467554&pathrev=1467555
> If you notice, the submitted patch has
> +            elif api_version == '5.1':
> +                cls = VCloud_5_1_NodeDriver
> Where as what was actually patched has 
> +            elif api_version == '5.1':
> +                cls = VCloud_1_5_NodeDriver

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira