You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by "daniellansun (via GitHub)" <gi...@apache.org> on 2026/07/26 10:33:23 UTC
[PR] GROOVY-12199: Replace ant-jarjar with com.gradleup.shadow for package relocation [groovy]
daniellansun opened a new pull request, #2740:
URL: https://github.com/apache/groovy/pull/2740
https://issues.apache.org/jira/browse/GROOVY-12199
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GROOVY-12199: Replace ant-jarjar with com.gradleup.shadow for package relocation [groovy]
Posted by "daniellansun (via GitHub)" <gi...@apache.org>.
daniellansun commented on PR #2740:
URL: https://github.com/apache/groovy/pull/2740#issuecomment-5107024182
@paulk-asert Does the commit ( https://github.com/apache/groovy/pull/2740/changes/16f8e2305cbeffb9f75c600ef4d5e0fe7b9367a8 ) looks OK to you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GROOVY-12199: Replace ant-jarjar with com.gradleup.shadow for package relocation [groovy]
Posted by "paulk-asert (via GitHub)" <gi...@apache.org>.
paulk-asert merged PR #2740:
URL: https://github.com/apache/groovy/pull/2740
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GROOVY-12199: Replace ant-jarjar with com.gradleup.shadow for package relocation [groovy]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #2740:
URL: https://github.com/apache/groovy/pull/2740#issuecomment-5108506002
## [](https://sonarcloud.io/dashboard?id=apache_groovy&pullRequest=2740) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_groovy&pullRequest=2740&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_groovy&pullRequest=2740&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_groovy&pullRequest=2740&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_groovy&pullRequest=2740&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_groovy&pullRequest=2740&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_groovy&pullRequest=2740)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GROOVY-12199: Replace ant-jarjar with com.gradleup.shadow for package relocation [groovy]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #2740:
URL: https://github.com/apache/groovy/pull/2740#issuecomment-5083263769
### JMH summary — indy (commit `4e1bee3`)
Speedup vs trailing 90-day baseline on gh-pages. Higher = faster.
`1.00` = in line with history. Per-benchmark ratio, geomean within group.
Time-per-op units inverted so direction is consistent. The *calibrated*
column divides out this runner's speed vs the baseline hardware, as
measured by Groovy-independent pure-Java ruler benchmarks.
| Group | Speedup | Calibrated | n |
|--------|---------|------------|---|
| bench | 1.011 × | 0.962 × | 92 |
| core | 3.522 × | 3.581 × | 77 |
| grails | 2.159 × | 2.101 × | 80 |
<sub>Runner calibration (this run vs baseline hardware): bench 1.04× (26 rulers) · core-ag 1.00× (3 rulers) · core-hz 0.97× (3 rulers) · grails-ad 0.96× (3 rulers) · grails-ez 1.08× (3 rulers)</sub>
<sub>Baseline: <code>dev/bench/jmh/<part>/indy/data.js</code> on gh-pages, trailing 90 days. <a href="https://apache.github.io/groovy/dev/bench/jmh/summary.html">Daily dashboard</a> · <a href="https://apache.github.io/groovy/dev/bench/jmh/">Per-suite raw data</a></sub>
<!-- jmh-summary:indy -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GROOVY-12199: Replace ant-jarjar with com.gradleup.shadow for package relocation [groovy]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #2740:
URL: https://github.com/apache/groovy/pull/2740#issuecomment-5083241923
### JMH summary — classic (commit `4e1bee3`)
Speedup vs trailing 90-day baseline on gh-pages. Higher = faster.
`1.00` = in line with history. Per-benchmark ratio, geomean within group.
Time-per-op units inverted so direction is consistent. The *calibrated*
column divides out this runner's speed vs the baseline hardware, as
measured by Groovy-independent pure-Java ruler benchmarks.
| Group | Speedup | Calibrated | n |
|--------|---------|------------|---|
| bench | 1.072 × | 1.002 × | 92 |
| core | 1.047 × | 1.080 × | 77 |
| grails | 0.957 × | 0.909 × | 80 |
<sub>Runner calibration (this run vs baseline hardware): bench 1.07× (26 rulers) · core-ag 0.97× (3 rulers) · core-hz 0.97× (3 rulers) · grails-ad 0.97× (3 rulers) · grails-ez 1.13× (3 rulers)</sub>
<sub>Baseline: <code>dev/bench/jmh/<part>/classic/data.js</code> on gh-pages, trailing 90 days. <a href="https://apache.github.io/groovy/dev/bench/jmh/summary.html">Daily dashboard</a> · <a href="https://apache.github.io/groovy/dev/bench/jmh/">Per-suite raw data</a></sub>
<!-- jmh-summary:classic -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GROOVY-12199: Replace ant-jarjar with com.gradleup.shadow for package relocation [groovy]
Posted by "paulk-asert (via GitHub)" <gi...@apache.org>.
paulk-asert commented on PR #2740:
URL: https://github.com/apache/groovy/pull/2740#issuecomment-5099648237
AI read of differences, others don't seem to matter:
> Bucket 4a — Java9.class in the grooid jar · the one genuine semantic divergence
>
> The grooid relocation maps java.beans.** → groovyjarjaropenbeans, and shadow rewrote a string literal "java.beans" → "groovyjarjaropenbeans" in Java9.JAVA8_PACKAGES(). jarjar left it intact. That array (source comment: "should NOT be changed!") holds real JDK package names looked up against ModuleFinder.ofSystem() to decide which packages Groovy opens reflectively — "groovyjarjaropenbeans" isn't a real JDK package, so that lookup would no-op.
> - Scope: grooid (Android) jar only — the core jar's Java9.class is byte-identical.
> - Real-world impact: very likely inert (the Java9 plugin's static init needs java.lang.module, which doesn't exist on Android, so it won't load there). But it's an unintended bytecode change and the clearest example of shadow's more aggressive string-constant rewriting. Worth flagging to Daniel — ideally the java.beans.** grooid rule should suppress string-literal relocation (or the AutoComplete case too), to keep grooid bytecode faithful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GROOVY-12199: Replace ant-jarjar with com.gradleup.shadow for package relocation [groovy]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #2740:
URL: https://github.com/apache/groovy/pull/2740#issuecomment-5083216450
## [](https://sonarcloud.io/dashboard?id=apache_groovy&pullRequest=2740) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_groovy&pullRequest=2740&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_groovy&pullRequest=2740&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_groovy&pullRequest=2740&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_groovy&pullRequest=2740&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_groovy&pullRequest=2740&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_groovy&pullRequest=2740)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GROOVY-12199: Replace ant-jarjar with com.gradleup.shadow for package relocation [groovy]
Posted by "testlens-app[bot] (via GitHub)" <gi...@apache.org>.
testlens-app[bot] commented on PR #2740:
URL: https://github.com/apache/groovy/pull/2740#issuecomment-5083264126
## ✅ All tests passed ✅
🏷️ Commit: 64dd99f1c3dda8bc68ab54c407c83b6983febd0f
▶️ Tests: 106707 executed
⚪️ Checks: 31/31 completed
---
_Learn more about TestLens at [testlens.app](https://testlens.app)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GROOVY-12199: Replace ant-jarjar with com.gradleup.shadow for package relocation [groovy]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2740:
URL: https://github.com/apache/groovy/pull/2740#issuecomment-5083209761
## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2740?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 69.8656%. Comparing base ([`a2ff978`](https://app.codecov.io/gh/apache/groovy/commit/a2ff9787344eab17d1bddbf5632503676b53b5b8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`64dd99f`](https://app.codecov.io/gh/apache/groovy/commit/64dd99f1c3dda8bc68ab54c407c83b6983febd0f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/groovy/pull/2740?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #2740 +/- ##
==================================================
- Coverage 69.8702% 69.8656% -0.0046%
+ Complexity 35139 35138 -1
==================================================
Files 1554 1554
Lines 130731 130731
Branches 23916 23916
==================================================
- Hits 91342 91336 -6
- Misses 31144 31147 +3
- Partials 8245 8248 +3
```
[see 5 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/2740/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GROOVY-12199: Replace ant-jarjar with com.gradleup.shadow for package relocation [groovy]
Posted by "testlens-app[bot] (via GitHub)" <gi...@apache.org>.
testlens-app[bot] commented on PR #2740:
URL: https://github.com/apache/groovy/pull/2740#issuecomment-5108967622
## ✅ All tests passed ✅
🏷️ Commit: 16f8e2305cbeffb9f75c600ef4d5e0fe7b9367a8
▶️ Tests: 107013 executed
⚪️ Checks: 31/31 completed
---
_Learn more about TestLens at [testlens.app](https://testlens.app)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org