You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by zj...@apache.org on 2018/02/08 13:00:29 UTC
zeppelin git commit: ZEPPELIN-3208. Use interpreter setting's name as
its id
Repository: zeppelin
Updated Branches:
refs/heads/master f307392b0 -> b3ba458bd
ZEPPELIN-3208. Use interpreter setting's name as its id
### What is this PR for?
Interpreter setting's name is unique, so it is not necessary to use id to identify it. For now we use a random string to represent such id which is not easy to read especially when you read log for diagnose. But for backward compatibility, I will keep id and set it as the same as interpreter setting's name
### What type of PR is it?
[Improvement]
### Todos
* [ ] - Task
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-3208
### How should this be tested?
* CI pass
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
Author: Jeff Zhang <zj...@apache.org>
Closes #2778 from zjffdu/ZEPPELIN-3208 and squashes the following commits:
56a33c2 [Jeff Zhang] ZEPPELIN-3208. Use interpreter setting's name as its id
Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/b3ba458b
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/b3ba458b
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/b3ba458b
Branch: refs/heads/master
Commit: b3ba458bd22f4320162cbb4baf3bab48a6844b30
Parents: f307392
Author: Jeff Zhang <zj...@apache.org>
Authored: Wed Feb 7 18:25:46 2018 +0800
Committer: Jeff Zhang <zj...@apache.org>
Committed: Thu Feb 8 21:00:14 2018 +0800
----------------------------------------------------------------------
.../java/org/apache/zeppelin/interpreter/InterpreterSetting.java | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/zeppelin/blob/b3ba458b/zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterSetting.java
----------------------------------------------------------------------
diff --git a/zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterSetting.java b/zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterSetting.java
index 397ae10..bb44737 100644
--- a/zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterSetting.java
+++ b/zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterSetting.java
@@ -268,6 +268,7 @@ public class InterpreterSetting {
void postProcessing() {
this.status = Status.READY;
+ this.id = this.name;
if (this.lifecycleManager == null) {
this.lifecycleManager = new NullLifecycleManager(conf);
}
@@ -287,7 +288,7 @@ public class InterpreterSetting {
*/
public InterpreterSetting(InterpreterSetting o) {
this();
- this.id = generateId();
+ this.id = o.name;
this.name = o.name;
this.group = o.group;
this.properties = convertInterpreterProperties(