You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hive.apache.org by dm...@apache.org on 2019/12/07 15:52:37 UTC
[hive] branch master updated: HIVE-22571: Review of
ExprNodeFieldDesc Class (David Mollitor reviewed by Vinnet Garg)
This is an automated email from the ASF dual-hosted git repository.
dmollitor pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hive.git
The following commit(s) were added to refs/heads/master by this push:
new f13fc46 HIVE-22571: Review of ExprNodeFieldDesc Class (David Mollitor reviewed by Vinnet Garg)
f13fc46 is described below
commit f13fc46b49139682972f79d6258fc7f82d6d4e4b
Author: David Mollitor <dm...@apache.org>
AuthorDate: Sat Dec 7 10:51:58 2019 -0500
HIVE-22571: Review of ExprNodeFieldDesc Class (David Mollitor reviewed by Vinnet Garg)
---
.../org/apache/hadoop/hive/ql/plan/ExprNodeFieldDesc.java | 14 ++++++--------
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeFieldDesc.java b/ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeFieldDesc.java
index 12860db..8e0cd31 100755
--- a/ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeFieldDesc.java
+++ b/ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeFieldDesc.java
@@ -20,10 +20,11 @@ package org.apache.hadoop.hive.ql.plan;
import java.io.Serializable;
import java.util.ArrayList;
+import java.util.Collections;
+import java.util.LinkedHashSet;
import java.util.List;
import org.apache.commons.lang.builder.HashCodeBuilder;
-import org.apache.hadoop.hive.ql.exec.Utilities;
import org.apache.hadoop.hive.serde2.typeinfo.TypeInfo;
/**
@@ -53,9 +54,7 @@ public class ExprNodeFieldDesc extends ExprNodeDesc implements Serializable {
@Override
public List<ExprNodeDesc> getChildren() {
- List<ExprNodeDesc> children = new ArrayList<ExprNodeDesc>(2);
- children.add(desc);
- return children;
+ return Collections.singletonList(desc);
}
public ExprNodeDesc getDesc() {
@@ -94,11 +93,10 @@ public class ExprNodeFieldDesc extends ExprNodeDesc implements Serializable {
@Override
public List<String> getCols() {
- List<String> colList = new ArrayList<String>();
- if (desc != null) {
- colList = Utilities.mergeUniqElems(colList, desc.getCols());
+ if (desc == null) {
+ return Collections.emptyList();
}
- return colList;
+ return new ArrayList<>(new LinkedHashSet<>(desc.getCols()));
}
@Override