You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by sv...@apache.org on 2015/03/21 18:03:45 UTC
wicket git commit: WICKET-5861 cleanup: remove special handling of
empty string in Big*Converter and use #toBigInteger()
Repository: wicket
Updated Branches:
refs/heads/master b80f6640b -> 240972e09
WICKET-5861 cleanup: remove special handling of empty string in Big*Converter and use #toBigInteger()
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/240972e0
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/240972e0
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/240972e0
Branch: refs/heads/master
Commit: 240972e09f3fe0f0ee20e320a7fe136f791bd69e
Parents: b80f664
Author: Sven Meier <sv...@apache.org>
Authored: Sat Mar 21 18:03:30 2015 +0100
Committer: Sven Meier <sv...@apache.org>
Committed: Sat Mar 21 18:03:30 2015 +0100
----------------------------------------------------------------------
.../wicket/util/convert/converter/BigDecimalConverter.java | 5 -----
.../wicket/util/convert/converter/BigIntegerConverter.java | 7 +------
2 files changed, 1 insertion(+), 11 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/wicket/blob/240972e0/wicket-util/src/main/java/org/apache/wicket/util/convert/converter/BigDecimalConverter.java
----------------------------------------------------------------------
diff --git a/wicket-util/src/main/java/org/apache/wicket/util/convert/converter/BigDecimalConverter.java b/wicket-util/src/main/java/org/apache/wicket/util/convert/converter/BigDecimalConverter.java
index 162a6de..7b545e6 100644
--- a/wicket-util/src/main/java/org/apache/wicket/util/convert/converter/BigDecimalConverter.java
+++ b/wicket-util/src/main/java/org/apache/wicket/util/convert/converter/BigDecimalConverter.java
@@ -39,11 +39,6 @@ public class BigDecimalConverter extends AbstractDecimalConverter<BigDecimal>
@Override
public BigDecimal convertToObject(final String value, final Locale locale)
{
- if (Strings.isEmpty(value))
- {
- return null;
- }
-
return parse(value, null, null, locale);
}
}
http://git-wip-us.apache.org/repos/asf/wicket/blob/240972e0/wicket-util/src/main/java/org/apache/wicket/util/convert/converter/BigIntegerConverter.java
----------------------------------------------------------------------
diff --git a/wicket-util/src/main/java/org/apache/wicket/util/convert/converter/BigIntegerConverter.java b/wicket-util/src/main/java/org/apache/wicket/util/convert/converter/BigIntegerConverter.java
index 5da0034..42bb39c 100644
--- a/wicket-util/src/main/java/org/apache/wicket/util/convert/converter/BigIntegerConverter.java
+++ b/wicket-util/src/main/java/org/apache/wicket/util/convert/converter/BigIntegerConverter.java
@@ -40,11 +40,6 @@ public class BigIntegerConverter extends AbstractIntegerConverter<BigInteger>
@Override
public BigInteger convertToObject(final String value, final Locale locale)
{
- if (Strings.isEmpty(value))
- {
- return null;
- }
-
final BigDecimal number = parse(value, null, null, locale);
if (number == null)
@@ -52,6 +47,6 @@ public class BigIntegerConverter extends AbstractIntegerConverter<BigInteger>
return null;
}
- return new BigInteger(number.toString());
+ return number.toBigInteger();
}
}