You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by darionyaphet <gi...@git.apache.org> on 2015/02/12 16:47:42 UTC

[GitHub] storm pull request: SimpleTransportPlugin TThreadPoolServer

GitHub user darionyaphet opened a pull request:

    https://github.com/apache/storm/pull/430

    SimpleTransportPlugin TThreadPoolServer

    I'm reading storm's source code and I found it's very difference from version 0.9.3 . Storm Nimbus's ThriftServer is create by SimpleTransportPlugin. In getServer() function build a THsHaServer server to process supervisor's request . 
    I know TThreadPoolServer maybe support higher throughput and lesser lantency. So I make this pull request. 
    Also some config could be remove such as queueSize .


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/darionyaphet/storm master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/430.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #430
    
----
commit 4f0f9f4b3031137a8ad971f78f1dc6a210778516
Author: yaphet <da...@gmail.com>
Date:   2015-02-10T13:40:03Z

    Merge pull request #1 from apache/master
    
    merge update

commit 357f23abaf4abd09193b6446b797eddc2258375f
Author: darionyaphet <da...@gmail.com>
Date:   2015-02-12T15:36:50Z

    update transport plugin

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: SimpleTransportPlugin Using TThreadPoolServer

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/storm/pull/430


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: SimpleTransportPlugin Using TThreadPoolServer

Posted by d2r <gi...@git.apache.org>.

Github user d2r commented on the pull request:

    https://github.com/apache/storm/pull/430#issuecomment-81730400
  
    -0 unless we have evidence of a real performance issue that needs fixing here.
    
    @darionyaphet, If this pull request is related to an existing JIRA issue, it would help us out if you would update the title of this pull request with [STORM-X].  
    
    Here is a [link](https://issues.apache.org/jira/browse/STORM-510?jql=project%20%3D%20STORM%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20priority%20DESC) to some currently unresolved issues in the JIRA system, for reference.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: SimpleTransportPlugin Using TThreadPoolServer

Posted by d2r <gi...@git.apache.org>.

Github user d2r commented on the pull request:

    https://github.com/apache/storm/pull/430#issuecomment-167631376
  
    @darionyaphet, I will be closing this pull request soon since it is inactive.  Please re-open if it is a mistake.  If you do, it would be good to have a Jira issue and some performance numbers that demonstrate the issue.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---