[GitHub] nswamy commented on issue #12447: MXNET-884 - Clojure with-resources macro for Improved Memory Handling

[GitBox <gi...@apache.org>]

nswamy commented on issue #12447: MXNET-884 - Clojure with-resources macro for Improved Memory Handling
URL: https://github.com/apache/incubator-mxnet/pull/12447#issuecomment-420840596
 
 
   The work I am doing is here
   https://github.com/nswamy/incubator-mxnet/blob/using-handle/scala-package/core/src/main/scala/org/apache/mxnet/NativeResource.scala
   https://github.com/nswamy/incubator-mxnet/blob/using-handle/scala-package/core/src/main/scala/org/apache/mxnet/ResourceScope.scala
   https://github.com/nswamy/incubator-mxnet/blob/using-handle/scala-package/core/src/main/scala/org/apache/mxnet/NDArray.scala#L566-L570
   
   Do you think it makes sense to wait for these changes to get merged ? but i'll be fine if you want give this interim solution to users, however suggest to mark it experimental so you have the flexibility to modify.
   
   I am adding the NativeResource class so all the MXNet Objects that have native Resources can extend be automatically taken taken care of. NativeResource also implements AutoCloseable - is that something that Clojure can see?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services