You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/01/26 05:43:39 UTC

[jira] [Commented] (GROOVY-7627) Property calls are not correctly type checked if the setter parameter type or getter return type are not the field type

    [ https://issues.apache.org/jira/browse/GROOVY-7627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15116676#comment-15116676 ] 

ASF GitHub Bot commented on GROOVY-7627:
----------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/groovy/pull/139


> Property calls are not correctly type checked if the setter parameter type or getter return type are not the field type
> -----------------------------------------------------------------------------------------------------------------------
>
>                 Key: GROOVY-7627
>                 URL: https://issues.apache.org/jira/browse/GROOVY-7627
>             Project: Groovy
>          Issue Type: Bug
>          Components: Static Type Checker
>    Affects Versions: 2.4.5
>         Environment: JDK 1.8.0_60
>            Reporter: Shil Sinha
>            Assignee: Shil Sinha
>
> If a class defines a property but also explicitly provides a getter or setter, property style get/set calls are type checked using the underlying field type rather than the getter return type/setter parameter type.
> Setter example:
> {code}
> class Foo {
>     Bar bar;
>     void setBar(int x) {
>         this.bar = new Bar(x: x)
>     }
> }
> class Bar {
>     int x
> }
> @groovy.transform.TypeChecked
> void test() {
>     Foo foo = new Foo()
>     foo.bar = new Bar()
> }
> test()
> {code}
> The code above will pass STC and throw a GroovyCastException at runtime. Conversely, code like {{foo.bar = 1}} will not pass STC.  The case for getters with return type different from the field type is similar.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)