[Bug 60069] New: SamplerCreatorFactory.getSamplerCreator has two unused parameters

[bu...@apache.org]

https://bz.apache.org/bugzilla/show_bug.cgi?id=60069

            Bug ID: 60069
           Summary: SamplerCreatorFactory.getSamplerCreator has two unused
                    parameters
           Product: JMeter
           Version: 3.0
          Hardware: PC
                OS: Mac OS X 10.1
            Status: NEW
          Severity: normal
          Priority: P2
         Component: HTTP
          Assignee: issues@jmeter.apache.org
          Reporter: sebb@apache.org

The method
org.apache.jmeter.protocol.http.proxy.SamplerCreatorFactory.getSamplerCreator
only uses its first parameter - the two Map parameters are ignored.

The parameters could be dropped; or at least they could be documented as being
ignored.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 60069] SamplerCreatorFactory.getSamplerCreator has two unused parameters

[bu...@apache.org]

https://bz.apache.org/bugzilla/show_bug.cgi?id=60069

--- Comment #2 from UbikLoadPack support <su...@ubikloadpack.com> ---
Hello sebb,
If you intend to drop SamplerCreator.createSampler in the end, then you should
first deprecate the one with 2 parameters and make it call the new one in next
release , then drop the deprecated one in N+2 release.
Otherwise it will break plugins, for example we would be concerned by such
modification.

Thank you for taking into account this request.

Regards

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 60069] SamplerCreatorFactory.getSamplerCreator has two unused parameters

[bu...@apache.org]

https://bz.apache.org/bugzilla/show_bug.cgi?id=60069

--- Comment #1 from Sebb <se...@apache.org> ---
The interface method SamplerCreator.createSampler also does not need the
encoding Map parameters

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 60069] SamplerCreatorFactory.getSamplerCreator has two unused parameters

[bu...@apache.org]

https://bz.apache.org/bugzilla/show_bug.cgi?id=60069

Philippe Mouawad <p....@ubik-ingenierie.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |p.mouawad@ubik-ingenierie.c
                   |                            |om
           Hardware|PC                          |All
           Severity|normal                      |enhancement
                 OS|Mac OS X 10.1               |All

-- 
You are receiving this mail because:
You are the assignee for the bug.