You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Aleksandr Mashchenko (JIRA)" <ji...@apache.org> on 2015/03/04 18:20:09 UTC
[jira] [Commented] (WW-4457) FileUploadInterceptor uses injected
pattern matcher
[ https://issues.apache.org/jira/browse/WW-4457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14347189#comment-14347189 ]
Aleksandr Mashchenko commented on WW-4457:
------------------------------------------
[~lukaszlenart] Can't we just use {{@Inject("struts")}} on {{setMatcher}} setter?
> FileUploadInterceptor uses injected pattern matcher
> ---------------------------------------------------
>
> Key: WW-4457
> URL: https://issues.apache.org/jira/browse/WW-4457
> Project: Struts 2
> Issue Type: Bug
> Components: Core Interceptors
> Reporter: Aleksandr Mashchenko
> Fix For: 2.3.x
>
>
> Currently {{FileUploadInterceptor}} uses injected pattern matcher for checking {{allowedTypes}}, which yields inconsistent behavior with different default pattern matchers. Some mime types which are working fine with {{WildcardHelper}} are not working with the {{RegexPatternMatcher}}, because of the special regex character presented in them (e.g. {{image/svg+xml}} - {{+}} is a special character in regex).
> IMO file upload interceptor should use {{WildcardHelper}} no matter what pattern matcher is set as the default one. Or is there any point in injecting pattern matcher in file upload interceptor?
> Original report: [“Content-Type not allowed” while uploading an SVG file, that is in the allowed whitelist|http://stackoverflow.com/q/28304692/1700321]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)