You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/06/13 06:45:20 UTC
[GitHub] [tvm] alter-xp opened a new pull request, #11689: [CI Image] support CSI-NN2 in ci_qemu
alter-xp opened a new pull request, #11689:
URL: https://github.com/apache/tvm/pull/11689
Introduce CSI-NN2 Compute Library into TVM to accelerate the inference performance of RISC-V CPU with Vector Extension
* build CSI-NN2, download related toolchain and qemu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] alter-xp commented on a diff in pull request #11689: [CI Image] support CSI-NN2 in ci_qemu
Posted by GitBox <gi...@apache.org>.
alter-xp commented on code in PR #11689:
URL: https://github.com/apache/tvm/pull/11689#discussion_r897469435
##########
docker/install/ubuntu_download_csinn2_compute_lib.sh:
##########
@@ -0,0 +1,41 @@
+#!/bin/bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+set -e
+
+install_path="/opt/csi-nn2"
+
+# Clone CSI-NN2 Compute Library source code
+git clone https://github.com/T-head-Semi/csi-nn2.git ${install_path}
Review Comment:
Thanks for advice, we are glad to do so.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on pull request #11689: [CI Image] support CSI-NN2 in ci_qemu
Posted by GitBox <gi...@apache.org>.
areusch commented on PR #11689:
URL: https://github.com/apache/tvm/pull/11689#issuecomment-1162242945
thanks @alter-xp ! can you open an "Update Docker Image" [GH issue](https://github.com/apache/tvm/issues/new/choose) once the [nightly rebuild](https://ci.tlcpack.ai/blue/organizations/jenkins/docker-images-ci%2Fdaily-docker-image-validate/activity) has passed with this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] alter-xp commented on pull request #11689: [CI Image] support CSI-NN2 in ci_qemu
Posted by GitBox <gi...@apache.org>.
alter-xp commented on PR #11689:
URL: https://github.com/apache/tvm/pull/11689#issuecomment-1155900456
> thanks @alter-xp, once the RFC lands we can open a tracking issue for the RFC as a whole, tag this issue there, then land this change.
[a tracking issue](https://github.com/apache/tvm/issues/11506) is ready. I will keep updating it when RPC land.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] alter-xp commented on pull request #11689: [CI Image] support CSI-NN2 in ci_qemu
Posted by GitBox <gi...@apache.org>.
alter-xp commented on PR #11689:
URL: https://github.com/apache/tvm/pull/11689#issuecomment-1162814215
thanks @areusch. Actually, I already built [an issue](https://github.com/apache/tvm/issues/11688). I will keep updating it when the nightly rebuild has passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] alter-xp commented on pull request #11689: [CI Image] support CSI-NN2 in ci_qemu
Posted by GitBox <gi...@apache.org>.
alter-xp commented on PR #11689:
URL: https://github.com/apache/tvm/pull/11689#issuecomment-1158389697
okay, thanks @areusch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on pull request #11689: [CI Image] support CSI-NN2 in ci_qemu
Posted by GitBox <gi...@apache.org>.
areusch commented on PR #11689:
URL: https://github.com/apache/tvm/pull/11689#issuecomment-1158280929
hey @alter-xp i think our CI didn't quite do the right thing--#11756 should fix. it'd be great to retrigger CI on your PR after that goes in (i think i can do this myself, i'll ping you if not).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on a diff in pull request #11689: [CI Image] support CSI-NN2 in ci_qemu
Posted by GitBox <gi...@apache.org>.
areusch commented on code in PR #11689:
URL: https://github.com/apache/tvm/pull/11689#discussion_r897406494
##########
docker/install/ubuntu_download_csinn2_compute_lib.sh:
##########
@@ -0,0 +1,41 @@
+#!/bin/bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+set -e
+
+install_path="/opt/csi-nn2"
+
+# Clone CSI-NN2 Compute Library source code
+git clone https://github.com/T-head-Semi/csi-nn2.git ${install_path}
Review Comment:
we periodically rebuild images e.g. if we are going to update our Python version. do you guys mind pinning this version so we don't accidentally pull in new changes and break your tests in the process of updating something else?
also, possible to do a shallow clone e.g. `--depth=1` to keep the size of the CI images down?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch merged pull request #11689: [CI Image] support CSI-NN2 in ci_qemu
Posted by GitBox <gi...@apache.org>.
areusch merged PR #11689:
URL: https://github.com/apache/tvm/pull/11689
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org