[GitHub] [airflow] uranusjr commented on a change in pull request #19867: Initial commit for new Breeze project

[GitBox <gi...@apache.org>]

uranusjr commented on a change in pull request #19867:
URL: https://github.com/apache/airflow/pull/19867#discussion_r758200977



##########
File path: dev/Breeze/conftest.py
##########
@@ -0,0 +1,23 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+import sys
+from pathlib import Path
+
+ROOT_DIR = str(Path(__file__))
+
+sys.path.insert(1, ROOT_DIR)

Review comment:
       This would also not be needed is Breeze is an installable package!

##########
File path: dev/Breeze/requirements.txt
##########
@@ -0,0 +1,4 @@
+click
+pytest
+pytest-xdist
+rich

Review comment:
       I wonder if it’s be a good idea to distribute Breeze 2 on PyPI. The package would contain metadata (including dependencies) and a very small `Breeze` command that simply finds code in the checked-out Airflow repository to execute (so the bulk of the logic still lives with the Airflow source code and can be updated more easily). That’d make setup very straightforward.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org