You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/05/21 13:26:26 UTC
[GitHub] [mynewt-newt] michal-narajowski opened a new pull request #401: cmake: Make CMakeLists.txt more readable
michal-narajowski opened a new pull request #401:
URL: https://github.com/apache/mynewt-newt/pull/401
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-newt] michal-narajowski commented on pull request #401: cmake: Make CMakeLists.txt more readable
Posted by GitBox <gi...@apache.org>.
michal-narajowski commented on pull request #401:
URL: https://github.com/apache/mynewt-newt/pull/401#issuecomment-632097784
@kasjer I agree, I want to do that too, but it will require a bit more work as most of those long lines are generated from lists of flags or files. I will add another PR later that changes that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-newt] kasjer commented on pull request #401: cmake: Make CMakeLists.txt more readable
Posted by GitBox <gi...@apache.org>.
kasjer commented on pull request #401:
URL: https://github.com/apache/mynewt-newt/pull/401#issuecomment-632096208
CMakeLists.txt look much nicer now.
:+1:
But since you are changing style only maybe you could break lines to reasonable length (optionally).
Having lines with thousands of character is difficult to check.
But this is just a suggestion. It is improvement by itself. Great work as usual.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-newt] michal-narajowski merged pull request #401: cmake: Make CMakeLists.txt more readable
Posted by GitBox <gi...@apache.org>.
michal-narajowski merged pull request #401:
URL: https://github.com/apache/mynewt-newt/pull/401
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org