You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by "Indhumathi27 (via GitHub)" <gi...@apache.org> on 2024/11/05 04:53:41 UTC
[PR] HIVE-28519: Upgrade Maven SureFire Plugin to latest version 3.5.1 [hive]
Indhumathi27 opened a new pull request, #5530:
URL: https://github.com/apache/hive/pull/5530
### What changes were proposed in this pull request?
- Upgraded Maven SureFire Plugin to latest version 3.5.0
- Upgraded junit-jupiter-engine and junit.vintage.version to latest versions
- Fixed multiple test case failures post upgrading Maven SureFire Plugin
- Currently all testcases are not running in the pipeline. Current report is mentioned below
Test Result - 0 failures , 2,364 skipped Passed- 49,317 tests
- Many test cases are failing in BeforeClass post [HIVE-27972](https://issues.apache.org/jira/browse/HIVE-27972) and are getting skipped, instead of failing because of lower Maven surefire plugin. Testcases failures are due to incorrect hive configuration settings when running with Tez.
### Why are the changes needed?
1. To ensure all test cases are executed correctly.
2. To leverage the latest features and improvements of the Maven SureFire Plugin.
### Does this PR introduce _any_ user-facing change?
No. This change only affects the build and test process of the project, with no direct impact on the end users.
### Is the change a dependency upgrade?
Yes. The Maven SureFire Plugin is being upgraded from its current version to 3.5.1.
### How was this patch tested?
1. Verified that all existing unit and integration tests pass successfully with the upgraded plugin.
2. Ensured the build process completes without errors using the new plugin version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28519: Upgrade Maven SureFire Plugin to latest version 3.5.1 [hive]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #5530:
URL: https://github.com/apache/hive/pull/5530#issuecomment-2462452180
## [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=5530) **Quality Gate passed**
Issues
 [18 New issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=5530&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=5530&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=5530&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=5530&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=5530&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=5530)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28519: Upgrade Maven SureFire Plugin to latest version 3.5.1 [hive]
Posted by "abstractdog (via GitHub)" <gi...@apache.org>.
abstractdog commented on code in PR #5530:
URL: https://github.com/apache/hive/pull/5530#discussion_r1830965341
##########
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDTFGetSQLSchema.java:
##########
@@ -84,6 +96,8 @@ public void testWithSimpleTypes() throws Exception {
@Test
public void testWithDDL() throws Exception {
+ // Set the execution engine to mr to avoid the NPE exception in stats flow
+ conf.set("hive.execution.engine", "mr");
Review Comment:
in general, if a test fails with tez, and it's not convenient and easy to fix, it can stay on mr, but a ticket under HIVE-28027 is needed + comment like:
```
//TODO: HIVE-27998: TestGenericUDTFGetSQLSchema to run on Tez
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28519: Upgrade Maven SureFire Plugin to latest version 3.5.1 [hive]
Posted by "Indhumathi27 (via GitHub)" <gi...@apache.org>.
Indhumathi27 commented on PR #5530:
URL: https://github.com/apache/hive/pull/5530#issuecomment-2467275114
@zhangbutao looks like log4j is not compatible with the current junit versions, which in turn skipped tests.
I have added [HIVE-28417](https://issues.apache.org/jira/browse/HIVE-28417) back and upgraded junit version with [PR-5536](https://github.com/apache/hive/pull/5536) which has run all tests successfully.
I think we could take [HIVE-28417](https://issues.apache.org/jira/browse/HIVE-28417) back post this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28519: Upgrade Maven SureFire Plugin to latest version 3.5.1 [hive]
Posted by "abstractdog (via GitHub)" <gi...@apache.org>.
abstractdog commented on PR #5530:
URL: https://github.com/apache/hive/pull/5530#issuecomment-2467587131
> @abstractdog @zhangbutao @ayushtkn Addressed all the comments. Please help to review
you addressed what I was interested in, so this is +1 from my side
I can see that in the latest precommit there are 106412 tests running, which looks good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28519: Upgrade Maven SureFire Plugin to latest version 3.5.1 [hive]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #5530:
URL: https://github.com/apache/hive/pull/5530#issuecomment-2456312977
## [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=5530) **Quality Gate passed**
Issues
 [18 New issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=5530&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=5530&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=5530&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=5530&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=5530&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=5530)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28519: Upgrade Maven SureFire Plugin to latest version 3.5.1 [hive]
Posted by "abstractdog (via GitHub)" <gi...@apache.org>.
abstractdog merged PR #5530:
URL: https://github.com/apache/hive/pull/5530
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28519: Upgrade Maven SureFire Plugin to latest version 3.5.1 [hive]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #5530:
URL: https://github.com/apache/hive/pull/5530#issuecomment-2465634421
## [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=5530) **Quality Gate passed**
Issues
 [2 New issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=5530&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=5530&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=5530&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=5530&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=5530&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=5530)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28519: Upgrade Maven SureFire Plugin to latest version 3.5.1 [hive]
Posted by "abstractdog (via GitHub)" <gi...@apache.org>.
abstractdog commented on code in PR #5530:
URL: https://github.com/apache/hive/pull/5530#discussion_r1830965341
##########
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDTFGetSQLSchema.java:
##########
@@ -84,6 +96,8 @@ public void testWithSimpleTypes() throws Exception {
@Test
public void testWithDDL() throws Exception {
+ // Set the execution engine to mr to avoid the NPE exception in stats flow
+ conf.set("hive.execution.engine", "mr");
Review Comment:
in general, if a test fails with mr, and it's not convenient and easy to fix, it can stay on mr, but a ticket under HIVE-28027 is needed + comment like:
```
//TODO: HIVE-27998: TestGenericUDTFGetSQLSchema to run on Tez
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28519: Upgrade Maven SureFire Plugin to latest version 3.5.1 [hive]
Posted by "abstractdog (via GitHub)" <gi...@apache.org>.
abstractdog commented on PR #5530:
URL: https://github.com/apache/hive/pull/5530#issuecomment-2459673520
@Indhumathi27 : in general, can you remove the HiveTestEnvSetup and use the more compact HiveConfForTest where applicable? I started to make individual comments and then realized it's not needed to comment in all places :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28519: Upgrade Maven SureFire Plugin to latest version 3.5.1 [hive]
Posted by "Indhumathi27 (via GitHub)" <gi...@apache.org>.
Indhumathi27 commented on PR #5530:
URL: https://github.com/apache/hive/pull/5530#issuecomment-2456586061
On master branch:
<img width="1712" alt="Screenshot 2024-11-05 at 2 17 43 PM" src="https://github.com/user-attachments/assets/5ad4fff3-0907-4e3f-8fd4-e1ac3a69132c">
On this PR:
All test cases are running now.
<img width="1712" alt="Screenshot 2024-11-05 at 2 16 44 PM" src="https://github.com/user-attachments/assets/46d40cd2-8ebc-4f85-83ea-4d1c8e3b6464">
Sample Testcase which is getting skipped in master branch is attached below.
<img width="1712" alt="Screenshot 2024-11-05 at 2 23 27 PM" src="https://github.com/user-attachments/assets/02c5dcde-c7b0-4394-ae8e-e956f0d7d752">
<img width="1712" alt="Screenshot 2024-11-05 at 2 22 48 PM" src="https://github.com/user-attachments/assets/b2777ce0-2f15-49c3-9ed1-093fd1341fcf">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28519: Upgrade Maven SureFire Plugin to latest version 3.5.1 [hive]
Posted by "Indhumathi27 (via GitHub)" <gi...@apache.org>.
Indhumathi27 commented on PR #5530:
URL: https://github.com/apache/hive/pull/5530#issuecomment-2465259924
> @Indhumathi27 Thanks for your fix! Please see [HIVE-28611](https://issues.apache.org/jira/browse/HIVE-28611) about the skipped tests. Did [HIVE-28417](https://issues.apache.org/jira/browse/HIVE-28417) cause the skipped tests? Do you think [HIVE-28417](https://issues.apache.org/jira/browse/HIVE-28417) have other bad effect for current code base?
@zhangbutao Thanks for the review.
Actually, there are two issues here, where the testcases are getting skipped.
1. Post [HIVE-27972](https://issues.apache.org/jira/browse/HIVE-27972), HiveConf is not set properly for some testclasses to run on Tez engine, leading to failure in BeforeClass. Because of older maven surefire plugin version, failed tests were not reported.
2. I see, after [HIVE-28417](https://issues.apache.org/jira/browse/HIVE-28417) many tests in standalone-metastore module did not run itself. On checking console output of test pipelines, these tests are not identified during **splitTests** stage itself. We have to investigate which particular change of HIVE-28417 has caused this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28519: Upgrade Maven SureFire Plugin to latest version 3.5.1 [hive]
Posted by "ayushtkn (via GitHub)" <gi...@apache.org>.
ayushtkn commented on code in PR #5530:
URL: https://github.com/apache/hive/pull/5530#discussion_r1830448474
##########
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDTFGetSQLSchema.java:
##########
@@ -84,6 +96,8 @@ public void testWithSimpleTypes() throws Exception {
@Test
public void testWithDDL() throws Exception {
+ // Set the execution engine to mr to avoid the NPE exception in stats flow
+ conf.set("hive.execution.engine", "mr");
Review Comment:
was this test not running earlier?
##########
ql/src/test/org/apache/hadoop/hive/ql/exec/TestGetPartitionAuthWithBatches.java:
##########
@@ -50,6 +54,12 @@
public class TestGetPartitionAuthWithBatches {
+ @ClassRule
+ public static HiveTestEnvSetup env_setup = new HiveTestEnvSetup();
+
+ @Rule
+ public TestRule methodRule = env_setup.getMethodRule();
+
Review Comment:
I see these being added at multiple places, any pointers why it is needed in the scope of surefire upgrade?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28519: Upgrade Maven SureFire Plugin to latest version 3.5.1 [hive]
Posted by "abstractdog (via GitHub)" <gi...@apache.org>.
abstractdog commented on code in PR #5530:
URL: https://github.com/apache/hive/pull/5530#discussion_r1830962096
##########
ql/src/test/org/apache/hadoop/hive/ql/exec/TestGetPartitionInBatches.java:
##########
@@ -64,9 +76,9 @@ public class TestGetPartitionInBatches {
@BeforeClass
public static void setupClass() throws HiveException {
- hiveConf = new HiveConf(TestGetPartitionInBatches.class);
- hive = Hive.get();
- SessionState.start(hiveConf);
+ hiveConf = env_setup.getTestCtx().hiveConf;
+ SessionState ss = SessionState.start(hiveConf);
Review Comment:
same here:
```
new HiveConfForTest(TestGetPartitionInBatches.class)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28519: Upgrade Maven SureFire Plugin to latest version 3.5.1 [hive]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #5530:
URL: https://github.com/apache/hive/pull/5530#issuecomment-2464924771
## [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=5530) **Quality Gate passed**
Issues
 [1 New issue](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=5530&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=5530&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=5530&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=5530&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=5530&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=5530)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28519: Upgrade Maven SureFire Plugin to latest version 3.5.1 [hive]
Posted by "Indhumathi27 (via GitHub)" <gi...@apache.org>.
Indhumathi27 commented on code in PR #5530:
URL: https://github.com/apache/hive/pull/5530#discussion_r1830527996
##########
ql/src/test/org/apache/hadoop/hive/ql/exec/TestGetPartitionAuthWithBatches.java:
##########
@@ -50,6 +54,12 @@
public class TestGetPartitionAuthWithBatches {
+ @ClassRule
+ public static HiveTestEnvSetup env_setup = new HiveTestEnvSetup();
+
+ @Rule
+ public TestRule methodRule = env_setup.getMethodRule();
+
Review Comment:
These testcases were failing and not reported because of lower maven surefire plugin. So, when maven surefire plug-in is upgraded, all these test cases started failing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28519: Upgrade Maven SureFire Plugin to latest version 3.5.1 [hive]
Posted by "ayushtkn (via GitHub)" <gi...@apache.org>.
ayushtkn commented on code in PR #5530:
URL: https://github.com/apache/hive/pull/5530#discussion_r1830532752
##########
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDTFGetSQLSchema.java:
##########
@@ -84,6 +96,8 @@ public void testWithSimpleTypes() throws Exception {
@Test
public void testWithDDL() throws Exception {
+ // Set the execution engine to mr to avoid the NPE exception in stats flow
+ conf.set("hive.execution.engine", "mr");
Review Comment:
@abstractdog do you have any pointers here? Can we live with it for now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28519: Upgrade Maven SureFire Plugin to latest version 3.5.1 [hive]
Posted by "zhangbutao (via GitHub)" <gi...@apache.org>.
zhangbutao commented on PR #5530:
URL: https://github.com/apache/hive/pull/5530#issuecomment-2459877011
@Indhumathi27 Thanks for your fix!
Please see HIVE-28611 about the skipped tests.
Did HIVE-28417 cause the skipped tests?
Do you think HIVE-28417 have other bad effect for current code base?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28519: Upgrade Maven SureFire Plugin to latest version 3.5.1 [hive]
Posted by "Indhumathi27 (via GitHub)" <gi...@apache.org>.
Indhumathi27 commented on code in PR #5530:
URL: https://github.com/apache/hive/pull/5530#discussion_r1834706143
##########
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDTFGetSQLSchema.java:
##########
@@ -84,6 +96,8 @@ public void testWithSimpleTypes() throws Exception {
@Test
public void testWithDDL() throws Exception {
+ // Set the execution engine to mr to avoid the NPE exception in stats flow
+ conf.set("hive.execution.engine", "mr");
Review Comment:
Created JIRA's to run on tez and updates with a comment for the same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28519: Upgrade Maven SureFire Plugin to latest version 3.5.1 [hive]
Posted by "abstractdog (via GitHub)" <gi...@apache.org>.
abstractdog commented on code in PR #5530:
URL: https://github.com/apache/hive/pull/5530#discussion_r1830965341
##########
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDTFGetSQLSchema.java:
##########
@@ -84,6 +96,8 @@ public void testWithSimpleTypes() throws Exception {
@Test
public void testWithDDL() throws Exception {
+ // Set the execution engine to mr to avoid the NPE exception in stats flow
+ conf.set("hive.execution.engine", "mr");
Review Comment:
in general, if a test fails with tez, and it's not convenient and easy to fix, it can stay on mr, but a ticket under HIVE-28027 is needed + comment like:
```
//TODO: HIVE-xxxxx: TestGenericUDTFGetSQLSchema to run on Tez
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28519: Upgrade Maven SureFire Plugin to latest version 3.5.1 [hive]
Posted by "abstractdog (via GitHub)" <gi...@apache.org>.
abstractdog commented on PR #5530:
URL: https://github.com/apache/hive/pull/5530#issuecomment-2467787774
> if Laszlo is happy, I am happy :-)
>
> LGTM
and I'm happy, @zabetak I'm just letting you chime in if you want (with earlier surefire hacking experience), otherwise this is ready to be committed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28519: Upgrade Maven SureFire Plugin to latest version 3.5.1 [hive]
Posted by "Indhumathi27 (via GitHub)" <gi...@apache.org>.
Indhumathi27 commented on PR #5530:
URL: https://github.com/apache/hive/pull/5530#issuecomment-2467281832
@abstractdog @zhangbutao @ayushtkn Addressed all the comments. Please help to review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28519: Upgrade Maven SureFire Plugin to latest version 3.5.1 [hive]
Posted by "Indhumathi27 (via GitHub)" <gi...@apache.org>.
Indhumathi27 commented on PR #5530:
URL: https://github.com/apache/hive/pull/5530#issuecomment-2456232827
@zabetak Please help to review the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28519: Upgrade Maven SureFire Plugin to latest version 3.5.1 [hive]
Posted by "abstractdog (via GitHub)" <gi...@apache.org>.
abstractdog commented on code in PR #5530:
URL: https://github.com/apache/hive/pull/5530#discussion_r1830960684
##########
ql/src/test/org/apache/hadoop/hive/ql/exec/TestGetPartitionAuthWithBatches.java:
##########
@@ -50,6 +54,12 @@
public class TestGetPartitionAuthWithBatches {
+ @ClassRule
+ public static HiveTestEnvSetup env_setup = new HiveTestEnvSetup();
+
+ @Rule
+ public TestRule methodRule = env_setup.getMethodRule();
+
Review Comment:
while implementing since [HIVE-27972](https://issues.apache.org/jira/browse/HIVE-27972) I realized that this kind of boilerplate can be avoided by using a well-prepared hive conf, like:
```
new HiveConfForTest(getClass())
```
could this be used here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28519: Upgrade Maven SureFire Plugin to latest version 3.5.1 [hive]
Posted by "abstractdog (via GitHub)" <gi...@apache.org>.
abstractdog commented on code in PR #5530:
URL: https://github.com/apache/hive/pull/5530#discussion_r1830961530
##########
ql/src/test/org/apache/hadoop/hive/ql/exec/TestGetPartitionAuthWithBatches.java:
##########
@@ -67,7 +77,7 @@ public class TestGetPartitionAuthWithBatches {
@BeforeClass
public static void setupClass() throws HiveException {
- hiveConf = new HiveConf(TestGetPartitionAuthWithBatches.class);
+ hiveConf = env_setup.getTestCtx().hiveConf;
Review Comment:
as mentioned in the comment above, could this simply work with:
```
new HiveConfForTest(TestGetPartitionAuthWithBatches.class)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28519: Upgrade Maven SureFire Plugin to latest version 3.5.1 [hive]
Posted by "Indhumathi27 (via GitHub)" <gi...@apache.org>.
Indhumathi27 commented on PR #5530:
URL: https://github.com/apache/hive/pull/5530#issuecomment-2465240138
> @Indhumathi27 : in general, can you remove the HiveTestEnvSetup and use the more compact HiveConfForTest where applicable? I started to make individual comments and then realized it's not needed to comment in all places :)
@abstractdog Thanks for the review. You are right. Its better to use HiveConfForTest instead. I have updated with this. Please check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28519: Upgrade Maven SureFire Plugin to latest version 3.5.1 [hive]
Posted by "Indhumathi27 (via GitHub)" <gi...@apache.org>.
Indhumathi27 commented on PR #5530:
URL: https://github.com/apache/hive/pull/5530#issuecomment-2456591005
@ayushtkn @deniskuzZ Please help to review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28519: Upgrade Maven SureFire Plugin to latest version 3.5.1 [hive]
Posted by "Indhumathi27 (via GitHub)" <gi...@apache.org>.
Indhumathi27 commented on code in PR #5530:
URL: https://github.com/apache/hive/pull/5530#discussion_r1830529385
##########
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDTFGetSQLSchema.java:
##########
@@ -84,6 +96,8 @@ public void testWithSimpleTypes() throws Exception {
@Test
public void testWithDDL() throws Exception {
+ // Set the execution engine to mr to avoid the NPE exception in stats flow
+ conf.set("hive.execution.engine", "mr");
Review Comment:
Post Upgrade to Execution engine as Tez, this started failing and not reported.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org