You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "Yifan Mai (Jira)" <ji...@apache.org> on 2021/02/02 02:10:00 UTC

[jira] [Commented] (BEAM-11715) Combiner packing creates an incorrect proto

    [ https://issues.apache.org/jira/browse/BEAM-11715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17276795#comment-17276795 ] 

Yifan Mai commented on BEAM-11715:
----------------------------------

The changes from my previous comment are in draft #13877. Aiming to run integration tests and send out for review tomorrow.

> Combiner packing creates an incorrect proto
> -------------------------------------------
>
>                 Key: BEAM-11715
>                 URL: https://issues.apache.org/jira/browse/BEAM-11715
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-py-core
>            Reporter: Chamikara Madhusanka Jayalath
>            Assignee: Yifan Mai
>            Priority: P0
>             Fix For: 2.28.0
>
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> Seems like optimization creates a CombinePerKey transform that does not have any sub-transforms. We should fix this by preserving the old structure for CombinePerKey (GBK+CombineValues composite).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)