You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2020/10/09 23:27:52 UTC

[kudu-CR] docs: fix PK column order 

Hello Grant Henke,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/16578

to review the following change.


Change subject: docs: fix PK column order
......................................................................

docs: fix PK column order

I ran the query in Impala as written and it failed:

 Kudu PRIMARY KEY columns must be specified as the first columns in the table (expected leading columns ('sale_id', 'year') but found ('year', 'sale_id'))

Change-Id: I2a0986f28e49115cc972408ade497a823a36231d
---
M docs/kudu_impala_integration.adoc
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/78/16578/1
-- 
To view, visit http://gerrit.cloudera.org:8080/16578
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2a0986f28e49115cc972408ade497a823a36231d
Gerrit-Change-Number: 16578
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>

[kudu-CR] docs: fix PK column order

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16578 )

Change subject: docs: fix PK column order
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/16578
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a0986f28e49115cc972408ade497a823a36231d
Gerrit-Change-Number: 16578
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 10 Oct 2020 00:47:50 +0000
Gerrit-HasComments: No

[kudu-CR] docs: fix PK column order

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16578 )

Change subject: docs: fix PK column order
......................................................................

docs: fix PK column order

I ran the query in Impala as written and it failed:

 Kudu PRIMARY KEY columns must be specified as the first columns in the table (expected leading columns ('sale_id', 'year') but found ('year', 'sale_id'))

Change-Id: I2a0986f28e49115cc972408ade497a823a36231d
Reviewed-on: http://gerrit.cloudera.org:8080/16578
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M docs/kudu_impala_integration.adoc
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Kudu Jenkins: Verified
  Alexey Serbin: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/16578
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2a0986f28e49115cc972408ade497a823a36231d
Gerrit-Change-Number: 16578
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)