You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/04/01 00:45:54 UTC
[GitHub] [tvm] jwfromm opened a new pull request #7781: [Relay]Frontend][Onnx] Remove pop that interferes with nested loops.
jwfromm opened a new pull request #7781:
URL: https://github.com/apache/tvm/pull/7781
PR #7699 introduced a check for user provided shapes that arent found in the input graph. My implementation used `pop`, which it turns out can cause issues in nested loops. Unfortunately, its difficult to write a test case that triggers this error, but we should avoid pop in general. This PR replaces the pop based approach with a much safer way to check the same condition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jwfromm commented on pull request #7781: [Relay]Frontend][Onnx] Remove pop that interferes with nested loops.
Posted by GitBox <gi...@apache.org>.
jwfromm commented on pull request #7781:
URL: https://github.com/apache/tvm/pull/7781#issuecomment-812121989
@tmoreau89 yeah that new assert actually triggers for inner nested loops. I've changed it to only check in the outermost scope of the model which should be the sweet spot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tmoreau89 commented on pull request #7781: [Relay]Frontend][Onnx] Remove pop that interferes with nested loops.
Posted by GitBox <gi...@apache.org>.
tmoreau89 commented on pull request #7781:
URL: https://github.com/apache/tvm/pull/7781#issuecomment-812091327
Looks like the assertion that you modified is breaking CI: https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/PR-7781/1/pipeline @jwfromm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tmoreau89 merged pull request #7781: [Relay]Frontend][Onnx] Remove pop that interferes with nested loops.
Posted by GitBox <gi...@apache.org>.
tmoreau89 merged pull request #7781:
URL: https://github.com/apache/tvm/pull/7781
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tmoreau89 commented on pull request #7781: [Relay]Frontend][Onnx] Remove pop that interferes with nested loops.
Posted by GitBox <gi...@apache.org>.
tmoreau89 commented on pull request #7781:
URL: https://github.com/apache/tvm/pull/7781#issuecomment-812948236
Thank you @jwfromm @mbrookhart the PR has been merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org