You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2021/02/10 07:20:00 UTC

[jira] [Commented] (IMPALA-10469) Support pushing quickstart images to Apache repo

    [ https://issues.apache.org/jira/browse/IMPALA-10469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17282270#comment-17282270 ] 

ASF subversion and git services commented on IMPALA-10469:
----------------------------------------------------------

Commit 79bee3befbc6cdcd358373822a0a3b4d19ab5ce0 in impala's branch refs/heads/master from Tim Armstrong
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=79bee3b ]

IMPALA-10469: push quickstart to apache repo

This adds a script, docker/publish_images_to_apache.sh,
that allows uploading images to the apache/impala docker hub
repo, prefixed with a version string. E.g. with the following
commands:

  ninja docker_images quickstart_docker_images
  ./docker/publish_images_to_apache.sh -v 81d5377c2

The uploaded images can then be used for the quickstart cluster,
as documented in docker/README.

Updated docs for quickstart to use a prefix from apache/impala

Remove IMPALA_QUICKSTART_VERSION, which doesn't interact well with
the tagging since the image name and version are now encoded in the
tag.

Fix an incorrect image name added to docker-images.txt:
impala_profile_tool_image.

Testing:
Ran Impala quickstart with data loading using instructions in README.

  export IMPALA_QUICKSTART_IMAGE_PREFIX="apache/impala:81d5377c2-"
  docker network create -d bridge quickstart-network
  export QUICKSTART_IP=$(docker network inspect quickstart-network -f '{{(index .IPAM.Config 0).Gateway}}')
  export QUICKSTART_LISTEN_ADDR=$QUICKSTART_IP

  docker-compose -f docker/quickstart.yml \
      -f docker/quickstart-kudu-minimal.yml \
      -f docker/quickstart-load-data.yml up -d

  docker run --network=quickstart-network -it \
       ${IMPALA_QUICKSTART_IMAGE_PREFIX}impala_quickstart_client
       impala-shell

Change-Id: I535d77e565b73d732ae511d7525193467086c76a
Reviewed-on: http://gerrit.cloudera.org:8080/17030
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>


> Support pushing quickstart images to Apache repo
> ------------------------------------------------
>
>                 Key: IMPALA-10469
>                 URL: https://issues.apache.org/jira/browse/IMPALA-10469
>             Project: IMPALA
>          Issue Type: Sub-task
>          Components: Infrastructure
>            Reporter: Tim Armstrong
>            Assignee: Tim Armstrong
>            Priority: Major
>             Fix For: Impala 4.0
>
>
> We need a naming scheme and maybe a script to do the push. We've so far assumed a different repository for each image, but in the Apache docker, we only have a single repository and need to encode the image type and version into the tag
> See  https://hub.docker.com/repository/docker/apache/kudu for an example.
> They have:
> apache/kudu:<version>
> apache/kudu:kudu-python-<version>
> apache/kudu:impala-latest
> Airflow does the opposite, and this might be easier to use with IMPALA_QUICKSTART_IMAGE_PREFIX: 
> https://hub.docker.com/repository/registry-1.docker.io/apache/airflow/tags?page=1&ordering=last_updated



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org