[GitHub] [maven-jarsigner] elharo commented on pull request #2: [MJARSIGNER-65][MJARSIGNER-66] Update parent POM to 39, Java minimum to 1.8, maven minimum to 3.2.5

["elharo (via GitHub)" <gi...@apache.org>]

elharo commented on PR #2:
URL: https://github.com/apache/maven-jarsigner/pull/2#issuecomment-1501114911

   Reformatting is, perhaps unfortunately, a fundamental and unavoidable part of the upgrade to parent pom 39 due to the way the new parent pom is configured. Without the reformat the build is broken. Now that I think about it, splitting this into separate commits as I have done in some of these upgrade PRs means that the build is broken at commit that changes the parent pom version. That's going to make `git bisect` unreliable if we ever need to use it, and I shouldn't have done that. A single commit per project is what we need for these upgrades.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org