You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/12/15 21:51:13 UTC

[GitHub] [incubator-mxnet] waytrue17 commented on a change in pull request #19661: [WIP] Support _contrib_interleaved_matmul_selfatt_valatt to ONNX

waytrue17 commented on a change in pull request #19661:
URL: https://github.com/apache/incubator-mxnet/pull/19661#discussion_r543711979



##########
File path: python/mxnet/contrib/onnx/mx2onnx/_op_translations.py
##########
@@ -1656,16 +1657,15 @@ def convert_slice_axis(node, **kwargs):
     if not ends or ends == 'None':
         # ONNX doesn't support None for ends. Since ends=None depicts
         # length of dimension, passing dimension in this case.
-        in_shape = kwargs['in_shape'][0]
-        ends = in_shape[axes]
+        ends = sys.maxsize

Review comment:
       I reverted this change so we can have it fixed from you PR




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org