[GitHub] mistercrunch closed pull request #5211: [Bug fix] Divide by 1000.000 in epoch_ms_to_dttm() to not lose precision in Presto

[GitBox <gi...@apache.org>]

mistercrunch closed pull request #5211: [Bug fix] Divide by 1000.000 in epoch_ms_to_dttm() to not lose precision in Presto
URL: https://github.com/apache/incubator-superset/pull/5211
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/superset/db_engine_specs.py b/superset/db_engine_specs.py
index cbcc570934..2bd98f4c66 100644
--- a/superset/db_engine_specs.py
+++ b/superset/db_engine_specs.py
@@ -83,7 +83,7 @@ def epoch_to_dttm(cls):
 
     @classmethod
     def epoch_ms_to_dttm(cls):
-        return cls.epoch_to_dttm().replace('{col}', '({col}/1000.0)')
+        return cls.epoch_to_dttm().replace('{col}', '({col}/1000.000)')
 
     @classmethod
     def extra_table_metadata(cls, database, table_name, schema_name):


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org