Re: svn commit: r789714 - in /tomcat: container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/tcp/FastAsyncSocketSender.java container/tc5.5.x/webapps/docs/changelog.xml current/tc5.5.x/STATUS.txt

[Rainer Jung <ra...@kippdata.de>]

On 30.06.2009 15:29, sebb wrote:
> On 30/06/2009, rjung@apache.org <rj...@apache.org> wrote:
>> Author: rjung
>>  Date: Tue Jun 30 13:26:10 2009
>>  New Revision: 789714
>>
>>  URL: http://svn.apache.org/viewvc?rev=789714&view=rev
>>  Log:
>>  Separate statistics counter lock in FastAsyncSocketSender
>>  from inherited DataSender lock to reduce blocking during
>>  failed node detection.
>>
>>  Backport of http://svn.apache.org/viewvc?rev=759694&view=rev
>>  from OACC to tc5.5.x.

>>  +    private Object mutex = new Object();
> 
> Should be final as well to indicate that it must never be changed and
> to ensure safe publication across threads.

Thanks, +1. Proposed in STATUS file.

Regards,

Rainer

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org