You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by vsair <gi...@git.apache.org> on 2017/09/04 07:11:53 UTC
[GitHub] incubator-rocketmq pull request #162: [ROCKETMQ-286] Add a switch to decide ...
GitHub user vsair opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/162
[ROCKETMQ-286] Add a switch to decide whether to wake up commitLogService when put message
https://issues.apache.org/jira/browse/ROCKETMQ-286
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vsair/incubator-rocketmq ROCKETMQ-286
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rocketmq/pull/162.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #162
----
commit 6bc0b58c04339c5f24eb306c60b25c6dc8ec626d
Author: vsair <li...@gmail.com>
Date: 2017-09-04T07:09:54Z
[ROCKETMQ-286] Add a switch to decide whether to wake up commitLogService when put message
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #162: [ROCKETMQ-286] Add a switch to decide whether...
Posted by vsair <gi...@git.apache.org>.
Github user vsair commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/162
@zhouxinyu @vongosling pls have a review ?
---
[GitHub] incubator-rocketmq issue #162: [ROCKETMQ-286] Add a switch to decide whether...
Posted by vsair <gi...@git.apache.org>.
Github user vsair commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/162
@vongosling I'v modified the description.
---
[GitHub] incubator-rocketmq issue #162: [ROCKETMQ-286] Add a switch to decide whether...
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/162
[](https://coveralls.io/builds/13111287)
Coverage decreased (-0.2%) to 38.636% when pulling **6bc0b58c04339c5f24eb306c60b25c6dc8ec626d on vsair:ROCKETMQ-286** into **254d432496c424717d45b8dc9e44ae3bd78ab466 on apache:develop**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #162: [ROCKETMQ-286] Add a switch to decide whether...
Posted by dongeforever <gi...@git.apache.org>.
Github user dongeforever commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/162
@vsair @zhouxinyu another config flushCommitLogTimed has already handled such situation, and avoided SSD write amplification.
If flushCommitLogTimed is enabled, it will only wakeup the commitLogService, but could not wakeup the flushCommitLogService, for:
```
if (flushCommitLogTimed) {
Thread.sleep(interval);
} else {
this.waitForRunning(interval);
}
```
---
[GitHub] incubator-rocketmq issue #162: [ROCKETMQ-286] Add a switch to decide whether...
Posted by zhouxinyu <gi...@git.apache.org>.
Github user zhouxinyu commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/162
LGTM, wake up `commitLogService` is for real-time, but it may let broker suffer from SSD write amplification, so provide a switch is reasonable.
---
[GitHub] incubator-rocketmq issue #162: [ROCKETMQ-286] Add a switch to decide whether...
Posted by vsair <gi...@git.apache.org>.
Github user vsair commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/162
@zhouxinyu @lizhanhui @vongosling pls have a review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #162: [ROCKETMQ-286] Add a switch to decide whether...
Posted by vongosling <gi...@git.apache.org>.
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/162
@vsair Could you follow our new PR style for this PR, like https://github.com/apache/incubator-rocketmq/pull/152
---