You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/08/02 00:55:51 UTC
Review Request 61309: Imported ZooKeeper library.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61309/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos
Description
-------
This commit imports the ZooKeeper C Client as a library, and removes the
discrepancy between Linux and Windows. Both configurations now use
ZooKeeper 3.4.8, with an updated patch to both build with CMake.
Diffs
-----
3rdparty/CMakeLists.txt f4feaf90b4750338cfa2127524a5e6556a86d063
3rdparty/cmake/Mesos3rdpartyConfigure.cmake fa1202a5a6a7d37d94b52e2142528febd1b23a10
3rdparty/cmake/Versions.cmake 9586296420d76bd4493034fd710209008ee03595
Diff: https://reviews.apache.org/r/61309/diff/1/
Testing
-------
Thanks,
Andrew Schwartzmeyer
Re: Review Request 61309: Imported ZooKeeper library.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61309/#review183151
-----------------------------------------------------------
Ship it!
Hmm... I will not squash this one into the other library import reviews (more functional differences in this review compared to the other ones).
- Joseph Wu
On Aug. 8, 2017, 5:52 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61309/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2017, 5:52 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This commit imports the ZooKeeper C Client as a library, and removes the
> discrepancy between Linux and Windows. Both configurations now use
> ZooKeeper 3.4.8, with an updated patch to both build with CMake.
>
> Review: https://reviews.apache.org/r/61309
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt f4feaf90b4750338cfa2127524a5e6556a86d063
> 3rdparty/cmake/Mesos3rdpartyConfigure.cmake fa1202a5a6a7d37d94b52e2142528febd1b23a10
> 3rdparty/cmake/Versions.cmake 9586296420d76bd4493034fd710209008ee03595
>
>
> Diff: https://reviews.apache.org/r/61309/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 61309: Imported ZooKeeper library.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61309/
-----------------------------------------------------------
(Updated Aug. 8, 2017, 5:52 p.m.)
Review request for mesos.
Changes
-------
Move USE_STATIC_LIB definition to here.
Repository: mesos
Description (updated)
-------
This commit imports the ZooKeeper C Client as a library, and removes the
discrepancy between Linux and Windows. Both configurations now use
ZooKeeper 3.4.8, with an updated patch to both build with CMake.
Review: https://reviews.apache.org/r/61309
Diffs (updated)
-----
3rdparty/CMakeLists.txt f4feaf90b4750338cfa2127524a5e6556a86d063
3rdparty/cmake/Mesos3rdpartyConfigure.cmake fa1202a5a6a7d37d94b52e2142528febd1b23a10
3rdparty/cmake/Versions.cmake 9586296420d76bd4493034fd710209008ee03595
Diff: https://reviews.apache.org/r/61309/diff/2/
Changes: https://reviews.apache.org/r/61309/diff/1-2/
Testing
-------
Thanks,
Andrew Schwartzmeyer