You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Guenter Knauf <fu...@apache.org> on 2007/04/19 19:36:51 UTC
bug with Apache 1.3 NetWare build system
Hi Brad,
I've just found that we have same bug in the AP13 build system as what I fixed long time ago with the AP2x build system already; in each NWGNUmakefile.mak you can read:
#
# These flags will be added to the link.opt file
#
XLFLAGS += \
$(EOLIST)
but in fact the XLFLAGS dont go into the link.opt file but instead into the link.def file.
This does not work, and I'm unable to add additional libraries for linking....
the following patch fixes this:
--- NWGNUtail.inc.orig Wed Jul 12 10:16:06 2006
+++ NWGNUtail.inc Thu Apr 19 19:25:24 2007
@@ -220,7 +220,7 @@
@echo -l $(REGEX)\$(OBJDIR) >> $@
@echo -l $(STDMOD)\$(OBJDIR) >> $@
@echo -l $(NWOS)\$(OBJDIR) >> $@
-# @echo -l $(METROWERKS)\Novell Support\Metrowerks Support\Libraries\Runtime >> $@
+# @echo -l "$(METROWERKS)\Novell Support\Metrowerks Support\Libraries\Runtime" >> $@
@echo -l $(NWSDKDIR)\imports >> $@
@echo -l $(LDAPSDK)\Netware\clib\imports >> $@
@echo -nodefaults >> $@
@@ -240,6 +240,9 @@
ifneq "$(NLM_FLAGS)" ""
@echo -flags $(NLM_FLAGS) >> $@
endif
+ifneq "$(strip $(XLFLAGS))" ""
+ @echo $(strip $(XLFLAGS)) >> $@
+endif
ifneq "$(strip $(FILES_nlm_objs))" ""
@echo $(foreach objfile,$(strip $(FILES_nlm_objs)),$(subst /,\,$(objfile))) >> $@
endif
@@ -262,9 +265,6 @@
ifneq "$(FILES_nlm_exports)" ""
@echo Export $(foreach export,$(subst $(SPACE),$(COMMA),$(strip $(FILES_nlm_exports))),$(subst /,\,$(export))) >> $(OBJDIR)\$(NLM_NAME)_link.def
endif
-ifneq "$(strip $(XLFLAGS))" ""
- @echo $(strip $(XLFLAGS)) >> $(OBJDIR)\$(NLM_NAME)_link.def
-endif
#ifndef XDCFOUND
# @echo XDCData $(NWOS)\apache.xdc >> $(OBJDIR)\$(NLM_NAME)_link.def
#endif
can we get this into the Apache 1.3 source tree?
thanks, Guenter.
Re: bug with Apache 1.3 NetWare build system
Posted by Jim Jagielski <ji...@jaguNET.com>.
On Apr 23, 2007, at 1:20 PM, Brad Nicholes wrote:
>
> +1, go ahead and commit it.
>
> Brad
>
+1
Re: bug with Apache 1.3 NetWare build system
Posted by Brad Nicholes <BN...@novell.com>.
>>> On 4/19/2007 at 11:36 AM, in message
<XW...@akmail>, Guenter Knauf
<fu...@apache.org> wrote:
> Hi Brad,
> I've just found that we have same bug in the AP13 build system as what I
> fixed long time ago with the AP2x build system already; in each
> NWGNUmakefile.mak you can read:
> #
> # These flags will be added to the link.opt file
> #
> XLFLAGS += \
> $(EOLIST)
>
> but in fact the XLFLAGS dont go into the link.opt file but instead into the
> link.def file.
> This does not work, and I'm unable to add additional libraries for
> linking....
> the following patch fixes this:
>
> --- NWGNUtail.inc.orig Wed Jul 12 10:16:06 2006
> +++ NWGNUtail.inc Thu Apr 19 19:25:24 2007
> @@ -220,7 +220,7 @@
> @echo -l $(REGEX)\$(OBJDIR) >> $@
> @echo -l $(STDMOD)\$(OBJDIR) >> $@
> @echo -l $(NWOS)\$(OBJDIR) >> $@
> -# @echo -l $(METROWERKS)\Novell Support\Metrowerks Support\Libraries\Runtime >>
> $@
> +# @echo -l "$(METROWERKS)\Novell Support\Metrowerks
>Support\Libraries\Runtime" >> $@
> @echo -l $(NWSDKDIR)\imports >> $@
> @echo -l $(LDAPSDK)\Netware\clib\imports >> $@
> @echo -nodefaults >> $@
> @@ -240,6 +240,9 @@
> ifneq "$(NLM_FLAGS)" ""
> @echo -flags $(NLM_FLAGS) >> $@
> endif
> +ifneq "$(strip $(XLFLAGS))" ""
> + @echo $(strip $(XLFLAGS)) >> $@
> +endif
> ifneq "$(strip $(FILES_nlm_objs))" ""
> @echo $(foreach objfile,$(strip $(FILES_nlm_objs)),$(subst /,\,$(objfile)))
>>> $@
> endif
> @@ -262,9 +265,6 @@
> ifneq "$(FILES_nlm_exports)" ""
> @echo Export $(foreach export,$(subst $(SPACE),$(COMMA),$(strip
> $(FILES_nlm_exports))),$(subst /,\,$(export))) >>
> $(OBJDIR)\$(NLM_NAME)_link.def
> endif
> -ifneq "$(strip $(XLFLAGS))" ""
> - @echo $(strip $(XLFLAGS)) >> $(OBJDIR)\$(NLM_NAME)_link.def
> -endif
> #ifndef XDCFOUND
> # @echo XDCData $(NWOS)\apache.xdc >> $(OBJDIR)\$(NLM_NAME)_link.def
> #endif
>
> can we get this into the Apache 1.3 source tree?
>
> thanks, Guenter.
+1, go ahead and commit it.
Brad