You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@rya.apache.org by kchilton2 <gi...@git.apache.org> on 2016/09/06 17:19:29 UTC

[GitHub] incubator-rya pull request #85: [WIP] Rya 151 - Benchmarking Tools

GitHub user kchilton2 opened a pull request:

    https://github.com/apache/incubator-rya/pull/85

    [WIP] Rya 151 - Benchmarking Tools

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kchilton2/incubator-rya RYA-151

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-rya/pull/85.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #85
    
----
commit 4f8890b072fa6909389b05f4ff2935b7587482c4
Author: Kevin Chilton <ke...@parsons.com>
Date:   2016-08-18T02:29:41Z

    RYA-151 Rya Query benchmark tool implemented using JMH.

commit 9e92581db5e0956caeea5c99a36e2d9e4f243ccd
Author: Kevin Chilton <ke...@parsons.com>
Date:   2016-09-02T20:30:00Z

    RYA-151 Implemented a PCJOptimizer benchmark tool.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rya pull request #85: RYA-151 - Benchmarking Tools

Posted by kchilton2 <gi...@git.apache.org>.
Github user kchilton2 commented on a diff in the pull request:

    https://github.com/apache/incubator-rya/pull/85#discussion_r78677735
  
    --- Diff: extras/indexing/src/main/java/mvm/rya/indexing/external/PrecomputedJoinStorageSupplier.java ---
    @@ -27,6 +27,7 @@
     import com.google.common.base.Optional;
     import com.google.common.base.Supplier;
     
    +import cern.colt.Arrays;
    --- End diff --
    
    That's likely a mistake. Good catch.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rya pull request #85: RYA-151 - Benchmarking Tools

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-rya/pull/85


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rya pull request #85: RYA-151 - Benchmarking Tools

Posted by kchilton2 <gi...@git.apache.org>.
Github user kchilton2 commented on a diff in the pull request:

    https://github.com/apache/incubator-rya/pull/85#discussion_r78677753
  
    --- Diff: extras/rya.benchmark/pom.xml ---
    @@ -0,0 +1,250 @@
    +<?xml version="1.0" encoding="UTF-8"?>
    +<!--
    +
    +    Licensed to the Apache Software Foundation (ASF) under one
    +    or more contributor license agreements.  See the NOTICE file
    +    distributed with this work for additional information
    +    regarding copyright ownership.  The ASF licenses this file
    +    to you under the Apache License, Version 2.0 (the
    +    "License"); you may not use this file except in compliance
    +    with the License.  You may obtain a copy of the License at
    +
    +        http://www.apache.org/licenses/LICENSE-2.0
    +
    +    Unless required by applicable law or agreed to in writing,
    +    software distributed under the License is distributed on an
    +    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +    KIND, either express or implied.  See the License for the
    +    specific language governing permissions and limitations
    +    under the License.
    +
    +-->
    +<project xmlns="http://maven.apache.org/POM/4.0.0" 
    +         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" 
    +         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
    +         
    +    <parent>
    +        <artifactId>rya.extras</artifactId>
    +        <groupId>org.apache.rya</groupId>
    +        <version>3.2.10-SNAPSHOT</version>
    +    </parent>
    +
    +    <modelVersion>4.0.0</modelVersion>
    +    <artifactId>rya.benchmark</artifactId>
    +
    +    <name>Apache Rya Benchmarks</name>
    +
    +    <dependencies>
    +        <!-- JMH Benchmark Framework dependencies -->
    +        <dependency>
    +            <groupId>org.openjdk.jmh</groupId>
    +            <artifactId>jmh-core</artifactId>
    +            <version>${jmh.version}</version>
    +        </dependency>
    +        <dependency>
    +            <groupId>org.openjdk.jmh</groupId>
    +            <artifactId>jmh-generator-annprocess</artifactId>
    +            <version>${jmh.version}</version>
    +            <scope>provided</scope>
    +        </dependency>
    +        
    +        <dependency>
    +            <groupId>org.apache.rya</groupId>
    +            <artifactId>rya.indexing</artifactId>
    +        </dependency>
    +        
    +        <dependency>
    +            <groupId>com.google.code.findbugs</groupId>
    +            <artifactId>jsr305</artifactId>
    +            <version>3.0.1</version>
    +        </dependency>
    +        
    +        <dependency>
    +            <groupId>com.google.guava</groupId>
    +            <artifactId>guava</artifactId>
    +        </dependency>
    +        
    +        <dependency>
    +            <groupId>junit</groupId>
    +            <artifactId>junit</artifactId>
    +            <scope>test</scope>
    +        </dependency>
    +        
    +        <dependency>
    +            <groupId>org.apache.accumulo</groupId>
    +            <artifactId>accumulo-minicluster</artifactId>
    +            <version>${accumulo.version}</version>
    +            <scope>test</scope>
    +        </dependency>
    +        
    +    </dependencies>
    +
    +    <properties>
    +        <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
    +
    +        <!--
    +            JMH version to use with this project.
    +          -->
    +        <jmh.version>1.13</jmh.version>
    +
    +        <!--
    +            Java source/target to use for compilation.
    +          -->
    +        <javac.target>1.8</javac.target>
    +
    +        <!--
    +            Name of the benchmark Uber-JAR to generate.
    +          -->
    +        <uberjar.name>benchmarks</uberjar.name>
    +    </properties>
    +
    +    <build>
    +        <resources>
    +            <resource>
    +                <directory>src/main/xsd</directory>
    +            </resource>
    +        </resources>
    +    
    +        <plugins>
    +            <plugin>
    +                <groupId>org.apache.maven.plugins</groupId>
    --- End diff --
    
    Which part specifically?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rya pull request #85: RYA-151 - Benchmarking Tools

Posted by amihalik <gi...@git.apache.org>.
Github user amihalik commented on a diff in the pull request:

    https://github.com/apache/incubator-rya/pull/85#discussion_r78775502
  
    --- Diff: extras/rya.benchmark/pom.xml ---
    @@ -0,0 +1,250 @@
    +<?xml version="1.0" encoding="UTF-8"?>
    +<!--
    +
    +    Licensed to the Apache Software Foundation (ASF) under one
    +    or more contributor license agreements.  See the NOTICE file
    +    distributed with this work for additional information
    +    regarding copyright ownership.  The ASF licenses this file
    +    to you under the Apache License, Version 2.0 (the
    +    "License"); you may not use this file except in compliance
    +    with the License.  You may obtain a copy of the License at
    +
    +        http://www.apache.org/licenses/LICENSE-2.0
    +
    +    Unless required by applicable law or agreed to in writing,
    +    software distributed under the License is distributed on an
    +    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +    KIND, either express or implied.  See the License for the
    +    specific language governing permissions and limitations
    +    under the License.
    +
    +-->
    +<project xmlns="http://maven.apache.org/POM/4.0.0" 
    +         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" 
    +         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
    +         
    +    <parent>
    +        <artifactId>rya.extras</artifactId>
    +        <groupId>org.apache.rya</groupId>
    +        <version>3.2.10-SNAPSHOT</version>
    +    </parent>
    +
    +    <modelVersion>4.0.0</modelVersion>
    +    <artifactId>rya.benchmark</artifactId>
    +
    +    <name>Apache Rya Benchmarks</name>
    +
    +    <dependencies>
    +        <!-- JMH Benchmark Framework dependencies -->
    +        <dependency>
    +            <groupId>org.openjdk.jmh</groupId>
    +            <artifactId>jmh-core</artifactId>
    +            <version>${jmh.version}</version>
    +        </dependency>
    +        <dependency>
    +            <groupId>org.openjdk.jmh</groupId>
    +            <artifactId>jmh-generator-annprocess</artifactId>
    +            <version>${jmh.version}</version>
    +            <scope>provided</scope>
    +        </dependency>
    +        
    +        <dependency>
    +            <groupId>org.apache.rya</groupId>
    +            <artifactId>rya.indexing</artifactId>
    +        </dependency>
    +        
    +        <dependency>
    +            <groupId>com.google.code.findbugs</groupId>
    +            <artifactId>jsr305</artifactId>
    +            <version>3.0.1</version>
    +        </dependency>
    +        
    +        <dependency>
    +            <groupId>com.google.guava</groupId>
    +            <artifactId>guava</artifactId>
    +        </dependency>
    +        
    +        <dependency>
    +            <groupId>junit</groupId>
    +            <artifactId>junit</artifactId>
    +            <scope>test</scope>
    +        </dependency>
    +        
    +        <dependency>
    +            <groupId>org.apache.accumulo</groupId>
    +            <artifactId>accumulo-minicluster</artifactId>
    +            <version>${accumulo.version}</version>
    +            <scope>test</scope>
    +        </dependency>
    +        
    +    </dependencies>
    +
    +    <properties>
    +        <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
    +
    +        <!--
    +            JMH version to use with this project.
    +          -->
    +        <jmh.version>1.13</jmh.version>
    +
    +        <!--
    +            Java source/target to use for compilation.
    +          -->
    +        <javac.target>1.8</javac.target>
    +
    +        <!--
    +            Name of the benchmark Uber-JAR to generate.
    +          -->
    +        <uberjar.name>benchmarks</uberjar.name>
    +    </properties>
    +
    +    <build>
    +        <resources>
    +            <resource>
    +                <directory>src/main/xsd</directory>
    +            </resource>
    +        </resources>
    +    
    +        <plugins>
    +            <plugin>
    +                <groupId>org.apache.maven.plugins</groupId>
    --- End diff --
    
    Sorry for my terse comment.  These should be defined in the parent POM:
    
    1. Versions for dependencies should be defined as parameters (e.g. like you've done with jmh.version).  You should also do this for maven plug-ins (e.g. you haven't done this for maven-clean-plugin).
    
    2. Dependencies (and plug-ins) and their versions should be defined in the DependenciesManagement (and pluginManagement) sections of the root pom.
    
    3. The root pom should be the only pom to define the java versions.  Subprojects shouldn't be using the maven-compiler-plugin to define their own versions of java.
    
    4. You have some nice plug-ins that should be moved to the root pom as well (e.g. license-maven-plugin).  I think @DLotts is working on this, so there's no need for you to modify that here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rya pull request #85: RYA-151 - Benchmarking Tools

Posted by amihalik <gi...@git.apache.org>.
Github user amihalik commented on a diff in the pull request:

    https://github.com/apache/incubator-rya/pull/85#discussion_r78671939
  
    --- Diff: extras/rya.benchmark/pom.xml ---
    @@ -0,0 +1,250 @@
    +<?xml version="1.0" encoding="UTF-8"?>
    +<!--
    +
    +    Licensed to the Apache Software Foundation (ASF) under one
    +    or more contributor license agreements.  See the NOTICE file
    +    distributed with this work for additional information
    +    regarding copyright ownership.  The ASF licenses this file
    +    to you under the Apache License, Version 2.0 (the
    +    "License"); you may not use this file except in compliance
    +    with the License.  You may obtain a copy of the License at
    +
    +        http://www.apache.org/licenses/LICENSE-2.0
    +
    +    Unless required by applicable law or agreed to in writing,
    +    software distributed under the License is distributed on an
    +    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +    KIND, either express or implied.  See the License for the
    +    specific language governing permissions and limitations
    +    under the License.
    +
    +-->
    +<project xmlns="http://maven.apache.org/POM/4.0.0" 
    +         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" 
    +         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
    +         
    +    <parent>
    +        <artifactId>rya.extras</artifactId>
    +        <groupId>org.apache.rya</groupId>
    +        <version>3.2.10-SNAPSHOT</version>
    +    </parent>
    +
    +    <modelVersion>4.0.0</modelVersion>
    +    <artifactId>rya.benchmark</artifactId>
    +
    +    <name>Apache Rya Benchmarks</name>
    +
    +    <dependencies>
    +        <!-- JMH Benchmark Framework dependencies -->
    +        <dependency>
    +            <groupId>org.openjdk.jmh</groupId>
    +            <artifactId>jmh-core</artifactId>
    +            <version>${jmh.version}</version>
    --- End diff --
    
    These versions should be defined in the root pom as properties and in the root pom's plug-in management section


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rya pull request #85: RYA-151 - Benchmarking Tools

Posted by amihalik <gi...@git.apache.org>.
Github user amihalik commented on a diff in the pull request:

    https://github.com/apache/incubator-rya/pull/85#discussion_r78671518
  
    --- Diff: extras/indexing/src/main/java/mvm/rya/indexing/external/PrecomputedJoinStorageSupplier.java ---
    @@ -27,6 +27,7 @@
     import com.google.common.base.Optional;
     import com.google.common.base.Supplier;
     
    +import cern.colt.Arrays;
    --- End diff --
    
    Is this correct?  Or do you mean `java.util.Arrays`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rya pull request #85: RYA-151 - Benchmarking Tools

Posted by amihalik <gi...@git.apache.org>.
Github user amihalik commented on a diff in the pull request:

    https://github.com/apache/incubator-rya/pull/85#discussion_r78671763
  
    --- Diff: extras/rya.benchmark/pom.xml ---
    @@ -0,0 +1,250 @@
    +<?xml version="1.0" encoding="UTF-8"?>
    +<!--
    +
    +    Licensed to the Apache Software Foundation (ASF) under one
    +    or more contributor license agreements.  See the NOTICE file
    +    distributed with this work for additional information
    +    regarding copyright ownership.  The ASF licenses this file
    +    to you under the Apache License, Version 2.0 (the
    +    "License"); you may not use this file except in compliance
    +    with the License.  You may obtain a copy of the License at
    +
    +        http://www.apache.org/licenses/LICENSE-2.0
    +
    +    Unless required by applicable law or agreed to in writing,
    +    software distributed under the License is distributed on an
    +    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +    KIND, either express or implied.  See the License for the
    +    specific language governing permissions and limitations
    +    under the License.
    +
    +-->
    +<project xmlns="http://maven.apache.org/POM/4.0.0" 
    +         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" 
    +         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
    +         
    +    <parent>
    +        <artifactId>rya.extras</artifactId>
    +        <groupId>org.apache.rya</groupId>
    +        <version>3.2.10-SNAPSHOT</version>
    +    </parent>
    +
    +    <modelVersion>4.0.0</modelVersion>
    +    <artifactId>rya.benchmark</artifactId>
    +
    +    <name>Apache Rya Benchmarks</name>
    +
    +    <dependencies>
    +        <!-- JMH Benchmark Framework dependencies -->
    +        <dependency>
    +            <groupId>org.openjdk.jmh</groupId>
    +            <artifactId>jmh-core</artifactId>
    +            <version>${jmh.version}</version>
    +        </dependency>
    +        <dependency>
    +            <groupId>org.openjdk.jmh</groupId>
    +            <artifactId>jmh-generator-annprocess</artifactId>
    +            <version>${jmh.version}</version>
    +            <scope>provided</scope>
    +        </dependency>
    +        
    +        <dependency>
    +            <groupId>org.apache.rya</groupId>
    +            <artifactId>rya.indexing</artifactId>
    +        </dependency>
    +        
    +        <dependency>
    +            <groupId>com.google.code.findbugs</groupId>
    +            <artifactId>jsr305</artifactId>
    +            <version>3.0.1</version>
    +        </dependency>
    +        
    +        <dependency>
    +            <groupId>com.google.guava</groupId>
    +            <artifactId>guava</artifactId>
    +        </dependency>
    +        
    +        <dependency>
    +            <groupId>junit</groupId>
    +            <artifactId>junit</artifactId>
    +            <scope>test</scope>
    +        </dependency>
    +        
    +        <dependency>
    +            <groupId>org.apache.accumulo</groupId>
    +            <artifactId>accumulo-minicluster</artifactId>
    +            <version>${accumulo.version}</version>
    +            <scope>test</scope>
    +        </dependency>
    +        
    +    </dependencies>
    +
    +    <properties>
    +        <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
    +
    +        <!--
    +            JMH version to use with this project.
    +          -->
    +        <jmh.version>1.13</jmh.version>
    +
    +        <!--
    +            Java source/target to use for compilation.
    +          -->
    +        <javac.target>1.8</javac.target>
    +
    +        <!--
    +            Name of the benchmark Uber-JAR to generate.
    +          -->
    +        <uberjar.name>benchmarks</uberjar.name>
    +    </properties>
    +
    +    <build>
    +        <resources>
    +            <resource>
    +                <directory>src/main/xsd</directory>
    +            </resource>
    +        </resources>
    +    
    +        <plugins>
    +            <plugin>
    +                <groupId>org.apache.maven.plugins</groupId>
    --- End diff --
    
    this should be define in the project's root pom


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---