You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Alexei Fedotov (JIRA)" <ji...@apache.org> on 2008/02/19 15:12:43 UTC

[jira] Created: (HARMONY-5529) [classlib][archive] creating JarFileInputStream only when sream verification is required

[classlib][archive] creating JarFileInputStream only when sream verification is required
----------------------------------------------------------------------------------------

                 Key: HARMONY-5529
                 URL: https://issues.apache.org/jira/browse/HARMONY-5529
             Project: Harmony
          Issue Type: Sub-task
            Reporter: Alexei Fedotov




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-5529) [classlib][archive] creating JarFileInputStream only when sream verification is required

Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexei Fedotov updated HARMONY-5529:
------------------------------------

    Attachment:     (was: jar_file_stream_review.patch)

> [classlib][archive] creating JarFileInputStream only when sream verification is required
> ----------------------------------------------------------------------------------------
>
>                 Key: HARMONY-5529
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5529
>             Project: Harmony
>          Issue Type: Sub-task
>            Reporter: Alexei Fedotov
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-5529) [classlib][archive] creating JarFileInputStream only when sream verification is required

Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexei Fedotov updated HARMONY-5529:
------------------------------------

    Attachment:     (was: jar_file_stream.patch)

> [classlib][archive] creating JarFileInputStream only when sream verification is required
> ----------------------------------------------------------------------------------------
>
>                 Key: HARMONY-5529
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5529
>             Project: Harmony
>          Issue Type: Sub-task
>            Reporter: Alexei Fedotov
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-5529) [classlib][archive] creating JarFileInputStream only when sream verification is required

Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexei Fedotov updated HARMONY-5529:
------------------------------------

    Attachment: test_improvements_read_tuning.patch

Tests updated, JarFileInputStream.read() fixed.

> [classlib][archive] creating JarFileInputStream only when sream verification is required
> ----------------------------------------------------------------------------------------
>
>                 Key: HARMONY-5529
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5529
>             Project: Harmony
>          Issue Type: Sub-task
>            Reporter: Alexei Fedotov
>         Attachments: jar_file_stream.patch, jar_file_stream_review.patch, jar_input_stream_read_tuning.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-5529) [classlib][archive] creating JarFileInputStream only when sream verification is required

Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexei Fedotov updated HARMONY-5529:
------------------------------------

    Attachment: jar_input_stream_read_tuning.patch

Run the tests correctly and fixed a bug.

> [classlib][archive] creating JarFileInputStream only when sream verification is required
> ----------------------------------------------------------------------------------------
>
>                 Key: HARMONY-5529
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5529
>             Project: Harmony
>          Issue Type: Sub-task
>            Reporter: Alexei Fedotov
>         Attachments: jar_file_stream.patch, jar_file_stream_review.patch, jar_input_stream_read_tuning.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-5529) [classlib][archive] creating JarFileInputStream only when sream verification is required

Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexei Fedotov updated HARMONY-5529:
------------------------------------

    Attachment:     (was: test_improvements_read_tuning.patch)

> [classlib][archive] creating JarFileInputStream only when sream verification is required
> ----------------------------------------------------------------------------------------
>
>                 Key: HARMONY-5529
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5529
>             Project: Harmony
>          Issue Type: Sub-task
>            Reporter: Alexei Fedotov
>         Attachments: jar_file_stream.patch, jar_file_stream_review.patch, jar_input_stream_read_tuning.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-5529) [classlib][archive] creating JarFileInputStream only when sream verification is required

Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexei Fedotov updated HARMONY-5529:
------------------------------------

    Attachment:     (was: jar_input_stream_read_tuning.patch)

> [classlib][archive] creating JarFileInputStream only when sream verification is required
> ----------------------------------------------------------------------------------------
>
>                 Key: HARMONY-5529
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5529
>             Project: Harmony
>          Issue Type: Sub-task
>            Reporter: Alexei Fedotov
>         Attachments: jar_file_stream.patch, jar_file_stream_review.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-5529) [classlib][archive] creating JarFileInputStream only when sream verification is required

Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexei Fedotov updated HARMONY-5529:
------------------------------------

    Attachment: jar_input_stream_read_tuning.patch

Used correct file name.

> [classlib][archive] creating JarFileInputStream only when sream verification is required
> ----------------------------------------------------------------------------------------
>
>                 Key: HARMONY-5529
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5529
>             Project: Harmony
>          Issue Type: Sub-task
>            Reporter: Alexei Fedotov
>         Attachments: jar_file_stream.patch, jar_file_stream_review.patch, jar_input_stream_read_tuning.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-5529) [classlib][archive] creating JarFileInputStream only when sream verification is required

Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexei Fedotov updated HARMONY-5529:
------------------------------------

    Patch Info: [Patch Available]

> [classlib][archive] creating JarFileInputStream only when sream verification is required
> ----------------------------------------------------------------------------------------
>
>                 Key: HARMONY-5529
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5529
>             Project: Harmony
>          Issue Type: Sub-task
>            Reporter: Alexei Fedotov
>         Attachments: jar_file_stream.patch, jar_file_stream_review.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-5529) [classlib][archive] creating JarFileInputStream only when sream verification is required

Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexei Fedotov updated HARMONY-5529:
------------------------------------

    Attachment: jar_file_stream.patch
                jar_file_stream_review.patch

The first parch ignores whitespace difference in tests. The second patch adds formatting changes as well.

The intention is to avoid creation of a new stream when no verification is intended. Better optimizations were inhibited by the fact that some JarEntry streams won't fit into byte array. 

> [classlib][archive] creating JarFileInputStream only when sream verification is required
> ----------------------------------------------------------------------------------------
>
>                 Key: HARMONY-5529
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5529
>             Project: Harmony
>          Issue Type: Sub-task
>            Reporter: Alexei Fedotov
>         Attachments: jar_file_stream.patch, jar_file_stream_review.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-5529) [classlib][archive] creating JarFileInputStream only when sream verification is required

Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexei Fedotov updated HARMONY-5529:
------------------------------------

    Attachment: jar_file_stream_review.patch
                jar_file_stream.patch

diff of JarEntryTest.java added, review patch manually cleaned up

> [classlib][archive] creating JarFileInputStream only when sream verification is required
> ----------------------------------------------------------------------------------------
>
>                 Key: HARMONY-5529
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5529
>             Project: Harmony
>          Issue Type: Sub-task
>            Reporter: Alexei Fedotov
>         Attachments: jar_file_stream.patch, jar_file_stream_review.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (HARMONY-5529) [classlib][archive] creating JarFileInputStream only when sream verification is required

Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexei Fedotov closed HARMONY-5529.
-----------------------------------

    Resolution: Fixed

Committed as a part of HARMONY-4569.

> [classlib][archive] creating JarFileInputStream only when sream verification is required
> ----------------------------------------------------------------------------------------
>
>                 Key: HARMONY-5529
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5529
>             Project: Harmony
>          Issue Type: Sub-task
>            Reporter: Alexei Fedotov
>         Attachments: jar_file_stream.patch, jar_file_stream_review.patch, jar_input_stream_read_tuning.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.