You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2016/03/05 22:35:18 UTC
[kudu-CR] Call enable-devtoolset.sh from build-if-necessary.sh
Hello Dan Burkert,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/2469
to review the following change.
Change subject: Call enable-devtoolset.sh from build-if-necessary.sh
......................................................................
Call enable-devtoolset.sh from build-if-necessary.sh
This makes it unnecessary to constantly specify enable-devtoolset.sh
when building on EL6.
Change-Id: Id9f83e50323f1721e71b847046dcdada12471647
---
M thirdparty/build-if-necessary.sh
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/69/2469/1
--
To view, visit http://gerrit.cloudera.org:8080/2469
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id9f83e50323f1721e71b847046dcdada12471647
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
[kudu-CR] Call enable-devtoolset.sh from build-if-necessary.sh
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has uploaded a new patch set (#2).
Change subject: Call enable-devtoolset.sh from build-if-necessary.sh
......................................................................
Call enable-devtoolset.sh from build-if-necessary.sh
This makes it unnecessary to constantly specify enable-devtoolset.sh
when building on EL6.
Also removed mention of it from the installation doc.
Change-Id: Id9f83e50323f1721e71b847046dcdada12471647
---
M docs/installation.adoc
M thirdparty/build-if-necessary.sh
2 files changed, 12 insertions(+), 18 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/69/2469/2
--
To view, visit http://gerrit.cloudera.org:8080/2469
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id9f83e50323f1721e71b847046dcdada12471647
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Call enable-devtoolset.sh from build-if-necessary.sh
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has abandoned this change.
Change subject: Call enable-devtoolset.sh from build-if-necessary.sh
......................................................................
Abandoned
I haven't found a way to do this well, shelving for now
--
To view, visit http://gerrit.cloudera.org:8080/2469
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: Id9f83e50323f1721e71b847046dcdada12471647
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Call enable-devtoolset.sh from build-if-necessary.sh
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: Call enable-devtoolset.sh from build-if-necessary.sh
......................................................................
Patch Set 1:
hrm, but the user still needs to know to do this when they run cmake, right?
--
To view, visit http://gerrit.cloudera.org:8080/2469
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id9f83e50323f1721e71b847046dcdada12471647
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Call enable-devtoolset.sh from build-if-necessary.sh
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: Call enable-devtoolset.sh from build-if-necessary.sh
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/2469/2/docs/installation.adoc
File docs/installation.adoc:
Line 262: ../../thirdparty/installed/bin/cmake -DCMAKE_BUILD_TYPE=release ../..
but devtoolset is still needed for cmake
--
To view, visit http://gerrit.cloudera.org:8080/2469
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id9f83e50323f1721e71b847046dcdada12471647
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] Call enable-devtoolset.sh from build-if-necessary.sh
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: Call enable-devtoolset.sh from build-if-necessary.sh
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/2469/2/docs/installation.adoc
File docs/installation.adoc:
Line 262: ../../thirdparty/installed/bin/cmake -DCMAKE_BUILD_TYPE=release ../..
> but devtoolset is still needed for cmake
hmm shoot you are right, i wonder if i can fix that
--
To view, visit http://gerrit.cloudera.org:8080/2469
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id9f83e50323f1721e71b847046dcdada12471647
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes