You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "wg1026688210 (via GitHub)" <gi...@apache.org> on 2023/03/31 08:45:54 UTC
[GitHub] [incubator-paimon] wg1026688210 opened a new pull request, #801: [hive] pass filesystem config to FileIO
wg1026688210 opened a new pull request, #801:
URL: https://github.com/apache/incubator-paimon/pull/801
fix #798
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] JingsongLi commented on a diff in pull request #801: [hive] pass filesystem config to FileIO
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on code in PR #801:
URL: https://github.com/apache/incubator-paimon/pull/801#discussion_r1154247319
##########
paimon-hive/paimon-hive-connector-common/src/main/java/org/apache/paimon/hive/HiveSchema.java:
##########
@@ -78,7 +78,7 @@ public static HiveSchema extract(@Nullable Configuration configuration, Properti
+ "so location property must be set.");
}
Path path = new Path(location);
- Options options = new Options();
+ Options options = PaimonJobConf.extractCatalogConfig(configuration);
Review Comment:
Add `if (configuration != null)` in `extractCatalogConfig`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] JingsongLi merged pull request #801: [hive] pass filesystem config to FileIO
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi merged PR #801:
URL: https://github.com/apache/incubator-paimon/pull/801
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org