[GitHub] tillrohrmann commented on a change in pull request #7064: [FLINK-10753] Improve propagation and logging of snapshot exceptions

[GitBox <gi...@apache.org>]

tillrohrmann commented on a change in pull request #7064: [FLINK-10753] Improve propagation and logging of snapshot exceptions
URL: https://github.com/apache/flink/pull/7064#discussion_r232468561
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/AbstractStreamOperator.java
 ##########
 @@ -413,8 +413,11 @@ public final OperatorSnapshotFutures snapshotState(long checkpointId, long times
 				snapshotException.addSuppressed(e);
 			}
 
-			throw new Exception("Could not complete snapshot " + checkpointId + " for operator " +
-				getOperatorName() + '.', snapshotException);
+			String snapshotFailMessage = "Could not complete snapshot " + checkpointId + " for operator " +
+				getOperatorName() + ".";
+
+			LOG.info(snapshotFailMessage, snapshotException);
 
 Review comment:
   I think it would be better to log the failure in `RpcCheckpointResponder#declineCheckpoint` because it is there where the message leaves the `TaskExecutor` and we no longer have control over it. Moreover, we would cover other failures coming from the other calling paths as well.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services